Fix gdb and other doctests #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But still return a `str` return for backwards-compatibility.
They appear to have to be a free standing block of `>>>` with an empty line above.
Arusekk
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't running a lot of the doctests due to them having text on the previous line. This was noticed due to tests added in #2233 having a typo but not failing (
executablevs.exeargument).It appears
is not run but
is.
There were multiple occasions throughout the code base which I've grepped for.
The GDB API doctests were never run due to the
.. doctestdirective trying to only run them on Python 3 having a typo. It should read.. doctest::. This revealed a problem with rpyc not being available in gdb's python environment which can be fixed by unsetting theLD_LIBRARY_PATHenvironment variable set by the setup-python Github Action 😄