Bugfix gdb.debug: exe parameter now respected #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit now properly supports the exe parameter in `pwnlib/gdb.py:debug()`, allowing a different argv[0] than the executable. It achieves this by leveraging the gdbsever`--wrapper` argument with a python script that calls execve with the specified args.
|
Hi, just wanted to ask if there are any changes you require me to make to the pull request or is it ready to merge? |
|
I didn't have time to test this yet :/ |
peace-maker
requested changes
Sep 12, 2023
This check checks prevents the use of "=" in the key of an environment variable, which is generally impossible.
peace-maker
requested changes
Sep 15, 2023
Co-authored-by: peace-maker <[email protected]>
1. explicit ctypes.CDLL('libc.so.6'), handle execve failing
2. consistent namedTempFile
3. drop packing._encode() since it's done earlier
4. testcases solve argv-args confusion
|
Please have a look at the test failures here: https://github.com/Gallopsled/pwntools/actions/runs/6259779607/job/16996463774?pr=2233#step:16:303 |
|
Ok, that passes the tests now. |
|
Actually the wrapper script could (and maybe should?) be reused with spawning carefully tailored remote processes over ssh, we already have a big Python function there. I think that function is not the best piece of code currently, but having two such functions is too many probably. |
|
I addressed the wrapper script now by creating a new function in Anything else that needs to be resolved? |
peace-maker
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #2227, since the Coverage tests didn't seem to handle changing the target branch correctly.
This commit now properly supports the exe parameter in
pwnlib/gdb.py:debug(), allowing a different argv[0] than the executable. (See Issue #1273 )It achieves this by leveraging the gdbsever
--wrapperargument with a python script that calls execve with the specified args.For remote connections
ssh.process(run=False)already creates a python script that we can use.Details
/tmp/pwn-XXXXXX.pygdbserverhas no native support forargv[0]Therefore we leverage the
--wrapperflag, which allows us to execute an arbitrary command.gdbserverwill attach to the first unforkedexecvesystem call.The command will then be
gdbserver --wrapper /tmp/pwn-XXXXXX.py -- <other gdbserver args>