-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run miniprot only once #25
Conversation
Ahh, the previous implementation would not work if multiple separate protein files were on input. That's fixed. The current implementation might still run into issues if the |
Also, I realized IDs might clash if miniprot is run separately on multiple files (that's related to the original implementation as well). tomasbruna/miniprothint@a38f300 should take care of that. |
The uptodate stuff does not work in all places, anyway. I should go through the code and remove it... in the early days for BRAKER, when we had a lot of crashes, we had that idea that users would continue a failed run after fixing BRAKER... but as I said: it's buggy, either way.
|
Our HPC is going into maintenance, tomorrow morning. I will run the tests on our end before merging. So the merge might take 2-3 days from now (depending on when our HPC awakens from its upgrade). Thank you so much for all the work that you put into this, Tomas!!! This is really good. |
I was hoping you'd say that :), it seems like a big headache to maintain it. |
If we at some point in time fully port to python, then snakemake (or Nextflow) would take care of this... timeline for this is very unsure on our end, though. I remove uptodate from the code for now.
|
…ost-hoc script, does not affect GALBA
Tested on test1.sh.
Also tested on large protein inputs - "miniprothint gtf" was always matching the one miniprot would produce natively.