-
Notifications
You must be signed in to change notification settings - Fork 206
Comparing changes
Open a pull request
base repository: GafferHQ/gaffer
base: 1.4.15.0
head repository: GafferHQ/gaffer
compare: 1.4_maintenance
Commits on Oct 31, 2024
-
PlugPopup : Fix error when popups have no PlugValueWidget
This could occur when a popup was created from multiple plugs of differing type, where we'd display a message rather than a PlugValueWidget.
Configuration menu - View commit details
-
Copy full SHA for d70acf7 - Browse repository at this point
Copy the full SHA d70acf7View commit details -
Merge pull request #6123 from murraystevenson/plugPopupFix
PlugPopup : Fix error when popups have no PlugValueWidget
Configuration menu - View commit details
-
Copy full SHA for 5e88e02 - Browse repository at this point
Copy the full SHA 5e88e02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57a21be - Browse repository at this point
Copy the full SHA 57a21beView commit details
Commits on Nov 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 863be3d - Browse repository at this point
Copy the full SHA 863be3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42f7ab3 - Browse repository at this point
Copy the full SHA 42f7ab3View commit details
Commits on Nov 19, 2024
-
Merge pull request #6137 from ericmehl/dropReadOnlyPathFilterFix
PathFilter : Fix dropping paths onto read-only nodes
Configuration menu - View commit details
-
Copy full SHA for 535a1b8 - Browse repository at this point
Copy the full SHA 535a1b8View commit details
Commits on Nov 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c1be2da - Browse repository at this point
Copy the full SHA c1be2daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ddf9b1 - Browse repository at this point
Copy the full SHA 7ddf9b1View commit details -
Merge pull request #6152 from murraystevenson/farewellGCC9
CI : Drop GCC9 builds for `1.4_maintenance`
Configuration menu - View commit details
-
Copy full SHA for b334e69 - Browse repository at this point
Copy the full SHA b334e69View commit details
Commits on Nov 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4a8b9fe - Browse repository at this point
Copy the full SHA 4a8b9feView commit details
Commits on Nov 27, 2024
-
GraphEditor config : Fix error in location drop handler
When the drag originates outside Gaffer, `event.sourceWidget` is `None`, in which case we were getting the following error : ``` ERROR : File "/home/john/dev/build/gaffer-1.4/startup/gui/graphEditor.py", line 253, in __dropLocationData ERROR : sourceEditor = event.sourceWidget.ancestor( GafferUI.Editor ) ERROR : AttributeError: 'NoneType' object has no attribute 'ancestor' ``` This had gone unnoticed before, because typically such events were being accepted by `__fileDragEnter()` first and never reached the location drop handler. But when the file is of an unhandled type, the file handler returns False and the location handler comes into play.
Configuration menu - View commit details
-
Copy full SHA for a698791 - Browse repository at this point
Copy the full SHA a698791View commit details -
Widget : Set
DragDropEvent.sourceWidget
from foreign dragsOur assumption was that such drags would always comes from outside of Gaffer - the foreign drag handling was originally added so that we could drag files from the system browser into the GraphEditor. In that case there is no source of information for `sourceWidget`. But some folks prefer to code their Gaffer extensions in pure Qt, with a tiny shim to host them in GafferUI. In this case, we _can_ find a suitable `sourceWidget`, which we now do.
Configuration menu - View commit details
-
Copy full SHA for 5d19325 - Browse repository at this point
Copy the full SHA 5d19325View commit details
Commits on Nov 30, 2024
-
Merge pull request #6163 from johnhaddon/dragDropFixes
Small drag & drop fixes
Configuration menu - View commit details
-
Copy full SHA for f45b0f1 - Browse repository at this point
Copy the full SHA f45b0f1View commit details
Commits on Dec 9, 2024
-
CatalogueUI : Don't "steal" irrelevant drags
We were accepting any drag which provided StringVectorData, when we should only have been accepting those which originated in the image listing (because we are using the drag to reorder images). This meant we were accepting drags of paths from the HierarchyView, and then clobbering the custom pointer in `__pathListingDragLeave`. This gave people the impression that the drag was broken, when in fact you could still continue and drop elsewhere (despite the pointer indicating otherwise). Also tweaked the drag move logic so we use exactly the same checks in both enter and move.
Configuration menu - View commit details
-
Copy full SHA for 300dda0 - Browse repository at this point
Copy the full SHA 300dda0View commit details -
Merge pull request #6168 from johnhaddon/catalogueDragFix
CatalogueUI : Don't "steal" irrelevant drags
Configuration menu - View commit details
-
Copy full SHA for dc38e12 - Browse repository at this point
Copy the full SHA dc38e12View commit details
Commits on Dec 10, 2024
-
GadgetWidget : Fix signal handling bug
This was broken in 9e05238, which switched from using a scoped to an unscoped connection. We need a scoped connection so that we automatically remove the connection to the previous viewport when making the connection to the new one.
Configuration menu - View commit details
-
Copy full SHA for 6d0ae46 - Browse repository at this point
Copy the full SHA 6d0ae46View commit details -
Merge pull request #6169 from johnhaddon/gadgetWidgetFix
GadgetWidget : Fix signal handling bug
Configuration menu - View commit details
-
Copy full SHA for f3b7898 - Browse repository at this point
Copy the full SHA f3b7898View commit details -
ArrayPlug : Fix loading of dynamic ArrayPlugs saved in Gaffer 1.5+
We changed the name of the `element` argument, and need to account for that in a compatibility shim. A further complication is that in 1.5 the ArrayPlug doesn't care what direction the prototype has, because it is just used as a factory via `createCounterpart()` which re-specifies the direction. But in 1.4 it is used as the first element of the array as well, so we need to adjust direction if necessary.
Configuration menu - View commit details
-
Copy full SHA for a39cdf0 - Browse repository at this point
Copy the full SHA a39cdf0View commit details -
RandomChoiceUI : Fix handling of non-ValuePlugs
Right-clicking on (for example) a `ShaderAssignment.shader` plug in the NodeEditor was leading to the following warning : ``` ERROR : Plug menu : Traceback (most recent call last): ERROR : File "/home/john/dev/build/gaffer-1.4/python/GafferUI/PlugValueWidget.py", line 994, in __combiner ERROR : next( results ) ERROR : IECore.Exception: Traceback (most recent call last): ERROR : File "/home/john/dev/build/gaffer-1.4/python/GafferUI/RandomChoiceUI.py", line 245, in __popupMenu ERROR : if not Gaffer.RandomChoice.canSetup( plug ) : ERROR : Boost.Python.ArgumentError: Python argument types in ERROR : RandomChoice.canSetup(ShaderPlug) ERROR : did not match C++ signature: ERROR : canSetup(Gaffer::ValuePlug const*) ```
Configuration menu - View commit details
-
Copy full SHA for 1d8403c - Browse repository at this point
Copy the full SHA 1d8403cView commit details -
Merge pull request #6179 from johnhaddon/arrayPlugCompat
ArrayPlug : Fix loading of dynamic ArrayPlugs saved in Gaffer 1.5+
Configuration menu - View commit details
-
Copy full SHA for fe384e4 - Browse repository at this point
Copy the full SHA fe384e4View commit details -
Merge pull request #6180 from johnhaddon/randomChoiceUIFix
RandomChoiceUI : Fix handling of non-ValuePlugs
Configuration menu - View commit details
-
Copy full SHA for 2e0c9ca - Browse repository at this point
Copy the full SHA 2e0c9caView commit details
Commits on Dec 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 97c574b - Browse repository at this point
Copy the full SHA 97c574bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.4.15.0...1.4_maintenance