Skip to content

Commit

Permalink
Merge pull request #6152 from murraystevenson/farewellGCC9
Browse files Browse the repository at this point in the history
CI : Drop GCC9 builds for `1.4_maintenance`
  • Loading branch information
johnhaddon authored Nov 20, 2024
2 parents 535a1b8 + 7ddf9b1 commit b334e69
Showing 1 changed file with 12 additions and 27 deletions.
39 changes: 12 additions & 27 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,18 @@ jobs:
# and then use `include` to define their settings.

name: [
linux-gcc9,
linux-debug-gcc9,
linux-gcc11,
linux-debug-gcc11,
windows,
]

include:

- name: linux-gcc9
- name: linux-gcc11
os: ubuntu-20.04
buildType: RELEASE
publish: true
containerImage: ghcr.io/gafferhq/build/build:2.1.2
containerImage: ghcr.io/gafferhq/build/build:3.0.0
# GitHub container builds run as root. This causes failures for tests that
# assert that filesystem permissions are respected, because root doesn't
# respect permissions. So we run the final test suite as a dedicated
Expand All @@ -49,31 +48,18 @@ jobs:
sconsCacheMegabytes: 400
jobs: 4

- name: linux-debug-gcc9
- name: linux-debug-gcc11
os: ubuntu-20.04
buildType: DEBUG
publish: false
containerImage: ghcr.io/gafferhq/build/build:2.1.2
containerImage: ghcr.io/gafferhq/build/build:3.0.0
testRunner: su testUser -c
testArguments: -excludedCategories performance
# Debug builds are ludicrously big, so we must use a larger cache
# limit. In practice this compresses down to 4-500Mb.
sconsCacheMegabytes: 2500
jobs: 4

- name: linux-gcc11
os: ubuntu-20.04
buildType: RELEASE
publish: true
containerImage: ghcr.io/gafferhq/build/build:3.0.0
# GitHub container builds run as root. This causes failures for tests that
# assert that filesystem permissions are respected, because root doesn't
# respect permissions. So we run the final test suite as a dedicated
# test user rather than as root.
testRunner: su testUser -c
sconsCacheMegabytes: 400
jobs: 4

- name: windows
os: windows-2019
buildType: RELEASE
Expand All @@ -93,16 +79,12 @@ jobs:
ARNOLD_FORCE_ABORT_ON_LICENSE_FAIL: 0 # And don't abort because the license isn't found
GAFFER_BUILD_DIR: "./build"
GAFFER_CACHE_DIR: "./sconsCache"
# GitHub have moved to running actions on Node20, which prevents them from
# running on CentOS 7. The below allows actions to continue running on Node16
# until October.
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

steps:

- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: ilammy/msvc-dev-cmd@v1.12.1
- uses: ilammy/msvc-dev-cmd@v1.13.0
with:
sdk: 10.0.17763.0

Expand Down Expand Up @@ -172,7 +154,7 @@ jobs:
if: runner.os == 'Windows'

- name: Cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ${{ env.GAFFER_CACHE_DIR }}
key: ${{ runner.os }}-${{ matrix.containerImage }}-${{env.GAFFER_DEPENDENCIES_HASH}}-${{ matrix.buildType }}-${{ github.sha }}
Expand Down Expand Up @@ -259,10 +241,13 @@ jobs:
echo "::remove-matcher owner=validateRelease::"
if: matrix.publish

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: ${{ env.GAFFER_BUILD_NAME }}
path: ${{ env.GAFFER_BUILD_NAME }}.${{ env.PACKAGE_EXTENSION }}
# Using compression-level 0 avoids compressing our already compressed
# package and results in a significantly faster upload.
compression-level: 0
if: matrix.publish

- name: Publish Release
Expand Down

0 comments on commit b334e69

Please sign in to comment.