Cycles updates #254
Merged
Cycles updates #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murraystevenson
approved these changes
Feb 8, 2024
The latter requires the `OPTIX_ROOT_DIR` environment variable to have been set in the build environment, but that is not our responsibility here. We want `GafferHQ/dependencies` to be as build-environment-agnostic as it can be, so other folks can use it to make their own builds in their own environments.
johnhaddon
force-pushed
the
cyclesUpdates
branch
from
e8f0191 to
82621d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in GafferHQ/gaffer#5659, this patches Cycles to use the more sensible IOR default values that are coming in 4.1. It also enables CUDA and Optix devices if suitable devkits are found in the environment (if they are not found, as in our GafferHQ/build 2.x containers, then CMake just warns and those devices are skipped).