Skip to content

Commit

Permalink
Merge pull request #254 from johnhaddon/cyclesUpdates
Browse files Browse the repository at this point in the history
Cycles updates
  • Loading branch information
johnhaddon authored Feb 9, 2024
2 parents 595ef86 + 82621d2 commit 7ea5229
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 2 deletions.
3 changes: 3 additions & 0 deletions Changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
-------------

- Cortex : Updated to version 10.5.6.0.
- Cycles :
- Patched shader `IOR` values to default to 1.5.
- Enabled CUDA and Optix devices.

8.0.0 alpha 4 (relative to 8.0.0 alpha 3)
-------------
Expand Down
5 changes: 3 additions & 2 deletions Cycles/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,10 @@
" -D CMAKE_BUILD_TYPE=Release"
" -D WITH_CYCLES_OPENIMAGEDENOISE=OFF"
" -D WITH_CYCLES_PATH_GUIDING=ON"
" -D WITH_CYCLES_DEVICE_CUDA=OFF"
" -D WITH_CYCLES_CUDA_BINARIES=ON"
" -D WITH_CYCLES_DEVICE_CUDA=ON"
" -D WITH_CYCLES_DEVICE_HIP=OFF"
" -D WITH_CYCLES_DEVICE_OPTIX=OFF"
" -D WITH_CYCLES_DEVICE_OPTIX=ON"
" -D WITH_CYCLES_HYDRA_RENDER_DELEGATE=OFF"
" -D CMAKE_POSITION_INDEPENDENT_CODE=ON"
" -D WITH_CYCLES_USD=OFF"
Expand Down
28 changes: 28 additions & 0 deletions Cycles/patches/iorDefaults.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
--- a/src/scene/shader_nodes.cpp
+++ b/src/scene/shader_nodes.cpp
@@ -2425,7 +2425,7 @@ NODE_DEFINE(GlassBsdfNode)
SOCKET_ENUM(
distribution, "Distribution", distribution_enum, CLOSURE_BSDF_MICROFACET_GGX_GLASS_ID);
SOCKET_IN_FLOAT(roughness, "Roughness", 0.0f);
- SOCKET_IN_FLOAT(IOR, "IOR", 0.3f);
+ SOCKET_IN_FLOAT(IOR, "IOR", 1.5f);

SOCKET_OUT_CLOSURE(BSDF, "BSDF");

@@ -2623,7 +2623,7 @@ NODE_DEFINE(PrincipledBsdfNode)
SOCKET_IN_COLOR(base_color, "Base Color", make_float3(0.8f, 0.8f, 0.8f))
SOCKET_IN_FLOAT(metallic, "Metallic", 0.0f);
SOCKET_IN_FLOAT(roughness, "Roughness", 0.5f);
- SOCKET_IN_FLOAT(ior, "IOR", 0.0f);
+ SOCKET_IN_FLOAT(ior, "IOR", 1.5f);
SOCKET_IN_FLOAT(alpha, "Alpha", 1.0f);
SOCKET_IN_NORMAL(normal, "Normal", zero_float3(), SocketType::LINK_NORMAL);

@@ -5781,7 +5781,7 @@ NODE_DEFINE(FresnelNode)

SOCKET_IN_NORMAL(
normal, "Normal", zero_float3(), SocketType::LINK_NORMAL | SocketType::OSL_INTERNAL);
- SOCKET_IN_FLOAT(IOR, "IOR", 1.45f);
+ SOCKET_IN_FLOAT(IOR, "IOR", 1.5f);

SOCKET_OUT_FLOAT(fac, "Fac");

0 comments on commit 7ea5229

Please sign in to comment.