Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotates sagittal acr images #445

Merged
merged 1 commit into from
Aug 28, 2024
Merged

rotates sagittal acr images #445

merged 1 commit into from
Aug 28, 2024

Conversation

rs-sprout98
Copy link
Collaborator

Rotates the slice thickness image 90 degrees clockwise if the image orientation is determined to be sagittal. Only works if original image is rotated 90 degrees anticlockwise.

Rotates the slice thickness image 90 degrees clockwise if the image orientation is determined to be sagittal. Only works if original image is rotated 90 degrees anticlockwise
Copy link

github-actions bot commented Aug 22, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
hazenlib
   ACRObject.py1121388%48, 82–88, 125, 140–143, 171–172, 210–213
   HazenTask.py29390%67–71
   __init__.py641773%104, 142–151, 153–162, 164–166, 185–191, 195
   exceptions.py21576%19–23, 42
   utils.py2406274%90, 94, 115, 128, 161, 176–189, 208, 215–222, 239, 246–248, 263–267, 283–287, 301, 326, 331, 342, 360, 422–423, 425–426, 431–456, 509, 512, 520–525, 528, 583, 592, 621
hazenlib/tasks
   acr_geometric_accuracy.py1115848%53–100, 124–239
   acr_ghosting.py1064260%42–58, 104–107, 154–157, 201–283
   acr_slice_position.py1364865%56–80, 281–348
   acr_slice_thickness.py1446654%47–79, 178, 256–340
   acr_snr.py1325757%60–111, 131, 227–242, 287–305, 355–380
   acr_spatial_resolution.py2066867%70–100, 187, 285, 302–313, 460–539
   acr_uniformity.py803260%43–60, 150–202
   ghosting.py1485265%28–47, 67, 168–169, 176, 193–194, 249–253, 268–272, 343–385
   relaxometry.py2918969%210–211, 213, 226–231, 238–246, 277–326, 375, 409–431, 609, 655–659, 726, 811–833, 851–866
   slice_position.py1244068%30, 43–71, 129–130, 157, 273, 283–306
   slice_width.py3525285%44–48, 52, 123, 188–213, 555, 560–561, 567, 572, 648–649, 1020–1084
   snr.py1736960%45–48, 87, 103–113, 206–225, 237–247, 287–302, 328–338, 343–359, 397–413, 426–432, 475–493
   snr_map.py108199%159
   spatial_resolution.py2464482%50–54, 58, 90, 213, 294, 460–501
   uniformity.py791976%59–63, 67, 118–119, 126, 174–204
TOTAL292783771% 

Tests Skipped Failures Errors Time
205 0 💤 0 ❌ 0 🔥 2m 20s ⏱️

Copy link
Collaborator

@mollybuckley mollybuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great Ryan! Approving these changes - thank you for doing this!

As discussed, we will temporarily update our local SOP with the correct direction to position the phantom - are you okay to follow that up with Becky?

As a next step, we can now look into detecting automatically whether the pixel array needs rotating clockwise or anti-clockwise and rotating accordingly.

@mollybuckley mollybuckley merged commit 49d6264 into main Aug 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants