Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACR Object orientation - bugfix #416

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Conversation

sophie22
Copy link
Collaborator

@sophie22 sophie22 commented Feb 29, 2024

Account for fluctuation in ImagePositionPatient values in all directions - assume that "true" orientation is where values across the image set are changing.
When the orientation cannot be determined from DICOM metadata values, error out and do not attempt to assume orientation. - In the future, provide an optional CLI argument to override orientation and provide the axis to be used for orientation.

Copy link

github-actions bot commented Feb 29, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
hazenlib
   ACRObject.py1091190%45, 80–86, 122, 137–140, 194–197
   HazenTask.py29390%67–71
   __init__.py571574%102, 135–144, 146–155, 157–159, 176–180, 184
   exceptions.py21576%19–23, 42
   utils.py2225973%77, 81, 102, 115, 148, 163–176, 195, 202–209, 226–228, 243–247, 263–267, 287, 292, 303, 375–376, 378–379, 384–409, 462, 465, 473–478, 481, 536, 545, 574
hazenlib/tasks
   acr_geometric_accuracy.py1115848%53–100, 124–239
   acr_ghosting.py1064260%42–58, 104–107, 154–157, 201–283
   acr_slice_position.py1364865%56–80, 281–348
   acr_slice_thickness.py1356056%45–64, 235–319
   acr_snr.py1325757%60–111, 131, 227–242, 287–305, 355–380
   acr_spatial_resolution.py2066867%70–100, 187, 285, 302–313, 460–539
   acr_uniformity.py803260%43–60, 150–202
   ghosting.py1495166%28–47, 67, 171–172, 179, 196–197, 252–256, 271–275, 346–387
   relaxometry.py2918969%210–211, 213, 226–231, 238–246, 277–326, 375, 409–431, 609, 655–659, 726, 811–833, 851–866
   slice_position.py1244068%30, 43–71, 129–130, 157, 273, 283–306
   slice_width.py3525285%44–48, 52, 123, 188–213, 555, 560–561, 567, 572, 648–649, 1020–1084
   snr.py1736960%45–48, 87, 103–113, 206–225, 237–247, 287–302, 330–340, 345–361, 399–415, 428–434, 477–495
   snr_map.py108199%159
   spatial_resolution.py2464482%50–54, 58, 90, 213, 294, 460–503
   uniformity.py791976%59–63, 67, 118–119, 126, 174–204
TOTAL289182372% 

Tests Skipped Failures Errors Time
208 0 💤 0 ❌ 0 🔥 2m 24s ⏱️

@sophie22 sophie22 changed the title 352 ACR Object orientation - hotfix ACR Object orientation - hotfix Feb 29, 2024
@sophie22 sophie22 changed the title ACR Object orientation - hotfix ACR Object orientation - bugfix Feb 29, 2024
@sophie22 sophie22 marked this pull request as ready for review February 29, 2024 13:56
@sophie22 sophie22 mentioned this pull request Feb 29, 2024
@mollybuckley mollybuckley merged commit 2aff227 into main Feb 29, 2024
4 checks passed
@mollybuckley mollybuckley deleted the 352-ACRobject_orientation branch February 29, 2024 14:21
@sophie22
Copy link
Collaborator Author

resolves #352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants