Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate documentation from docstrings #403

Merged
merged 31 commits into from
Feb 27, 2024
Merged

Conversation

sophie22
Copy link
Collaborator

@sophie22 sophie22 commented Jan 17, 2024

  • following on from 397 standardise docstrings #398 add more docstrings to previously overlooked scripts and functions
  • improve docstring formatting for better rendering on ReadTheDocs
  • add instructions to generating/updating documentation
  • move the relaxometry_params script into the data folder - this is to be excluded from documentation generation, so is the relaxometry task script itself

Copy link

github-actions bot commented Jan 17, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
hazenlib
   ACRObject.py1071190%94, 97–99, 104–107, 139, 193–196
   HazenTask.py29390%67–71
   __init__.py571574%102, 135–144, 146–155, 157–159, 176–180, 184
   exceptions.py21576%19–23, 42
   utils.py1894377%76, 80, 101, 114, 147, 162–175, 194, 201–208, 225–227, 242–246, 262–266, 286, 291, 302, 359, 362, 370–375, 378, 433, 442, 471
hazenlib/tasks
   acr_geometric_accuracy.py1125848%53–100, 124–239
   acr_ghosting.py1074261%42–58, 102–105, 152–155, 203–285
   acr_slice_position.py1364865%56–80, 282–349
   acr_slice_thickness.py1356056%44–63, 236–320
   acr_snr.py1345857%45, 60–111, 131, 227–242, 286–304, 354–379
   acr_spatial_resolution.py2076867%69–100, 188, 286, 303–314, 460–539
   acr_uniformity.py803260%43–60, 145–197
   ghosting.py1495166%28–47, 67, 171–172, 179, 196–197, 252–256, 271–275, 346–387
   relaxometry.py2918969%210–211, 213, 226–231, 238–246, 277–326, 375, 409–431, 609, 655–659, 726, 811–833, 851–866
   slice_position.py1244068%30, 43–71, 129–130, 157, 273, 283–306
   slice_width.py3525285%44–48, 52, 123, 188–213, 555, 560–561, 567, 572, 648–649, 1020–1084
   snr.py1736960%45–48, 87, 103–113, 206–225, 237–247, 287–302, 330–340, 345–361, 399–415, 428–434, 477–495
   snr_map.py108199%157
   spatial_resolution.py2464482%50–54, 58, 90, 213, 294, 460–503
   uniformity.py801976%59–63, 67, 118–119, 126, 175–205
TOTAL286280872% 

Tests Skipped Failures Errors Time
198 0 💤 0 ❌ 0 🔥 2m 17s ⏱️

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
hazenlib
   ACRObject.py1071190%94, 97–99, 104–107, 139, 192–195
   HazenTask.py28389%67–71
   __init__.py561573%102, 135–144, 146–155, 157–159, 176–180, 184
   exceptions.py21576%19–23, 42
   utils.py1894377%76, 80, 101, 114, 147, 162–175, 194, 201–208, 226–228, 245–249, 267–271, 291, 296, 307, 364, 367, 375–380, 383, 438, 447, 476
hazenlib/tasks
   acr_geometric_accuracy.py1196248%54–101, 119–165, 186–255
   acr_ghosting.py1074261%46–62, 105–107, 159–161, 211–293
   acr_slice_position.py1364865%59–83, 286–353
   acr_slice_thickness.py1366056%48–67, 238–322
   acr_snr.py1345857%47, 62–113, 132, 227–242, 283–301, 348–373
   acr_spatial_resolution.py2076867%69–100, 188, 286, 303–314, 460–539
   acr_uniformity.py813260%47–64, 148–200
   ghosting.py1505265%28–47, 67, 171–172, 179, 196–197, 252–256, 271–275, 346–387
   relaxometry.py2908969%210–211, 213, 226–231, 238–246, 277–326, 375, 409–431, 609, 655–659, 726, 811–833, 851–866
   slice_position.py1244068%30, 43–71, 129–130, 157, 273, 283–306
   slice_width.py3515385%44–48, 52, 123, 188–213, 383, 555, 560–561, 567, 572, 648–649, 1020–1084
   snr.py1736960%45–48, 87, 103–113, 206–225, 237–247, 287–302, 330–340, 345–361, 399–415, 428–434, 477–495
   snr_map.py107199%157
   spatial_resolution.py2464582%50–54, 58, 90, 191, 213, 294, 460–503
   uniformity.py801976%59–63, 67, 118–119, 126, 175–205
TOTAL286781572% 

Tests Skipped Failures Errors Time
198 0 💤 0 ❌ 0 🔥 2m 15s ⏱️

@sophie22
Copy link
Collaborator Author

ReadTheDocs is able to build documentation!!!

@sophie22 sophie22 marked this pull request as ready for review February 13, 2024 10:52
@sophie22 sophie22 requested a review from tomaroberts February 15, 2024 13:24
@sophie22
Copy link
Collaborator Author

Latest documentation built on ReadTheDocs: https://hazen.readthedocs.io/en/397-standardise-docstrings/

tomaroberts
tomaroberts previously approved these changes Feb 26, 2024
Copy link
Collaborator

@tomaroberts tomaroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sophie22 – just a couple of minor comments and changes to comments.

hazenlib/tasks/ghosting.py Outdated Show resolved Hide resolved
hazenlib/utils.py Outdated Show resolved Hide resolved
hazenlib/utils.py Outdated Show resolved Hide resolved
hazenlib/utils.py Outdated Show resolved Hide resolved
hazenlib/utils.py Show resolved Hide resolved
@tomaroberts tomaroberts self-requested a review February 27, 2024 10:33
@tomaroberts tomaroberts merged commit 583ea4f into main Feb 27, 2024
4 checks passed
@tomaroberts tomaroberts deleted the 397-standardise-docstrings branch February 27, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants