Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

397 standardise docstrings #398

Merged
merged 33 commits into from
Jan 17, 2024
Merged

397 standardise docstrings #398

merged 33 commits into from
Jan 17, 2024

Conversation

sophie22
Copy link
Collaborator

@sophie22 sophie22 commented Jan 2, 2024

Add a description for every function in hazen task scripts in consistent Google style to enable automated generation of documentation using Sphinx and ReadTheDocs

@sophie22 sophie22 linked an issue Jan 2, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jan 4, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
hazenlib
   ACRObject.py1071190%92, 95–97, 102–105, 143, 199–202
   HazenTask.py28389%43–47
   __init__.py561573%173, 205–214, 216–225, 227–229, 246–250, 254
   exceptions.py21576%19–23, 42
   utils.py1894377%72, 76, 86, 91, 130, 137–150, 161, 168–175, 195–197, 215–219, 238–242, 251, 256, 267, 319, 322, 330–335, 338, 385, 394, 409
hazenlib/tasks
   acr_geometric_accuracy.py1196248%54–101, 119–165, 186–255
   acr_ghosting.py1074261%46–62, 105–107, 159–161, 211–293
   acr_slice_position.py1364865%59–83, 286–353
   acr_slice_thickness.py1366056%48–67, 238–322
   acr_snr.py1345857%47, 62–113, 132, 227–242, 283–301, 348–373
   acr_spatial_resolution.py2076867%69–100, 188, 286, 303–314, 460–539
   acr_uniformity.py813260%47–64, 148–200
   ghosting.py1495166%28–47, 67, 171–172, 179, 196–197, 252–256, 271–275, 346–387
   relaxometry.py2908969%210–211, 213, 226–231, 238–246, 277–326, 375, 409–431, 609, 655–659, 726, 811–833, 851–866
   slice_position.py1244068%30, 43–71, 129–130, 157, 273, 283–306
   slice_width.py3515385%44–48, 52, 123, 188–213, 383, 555, 560–561, 567, 572, 648–649, 1021–1085
   snr.py1736960%45–48, 87, 103–113, 206–225, 237–247, 287–302, 330–340, 345–361, 399–415, 428–434, 477–495
   snr_map.py107199%157
   spatial_resolution.py2464582%50–54, 58, 90, 191, 213, 294, 460–503
   uniformity.py801976%59–63, 67, 118–119, 126, 175–205
TOTAL286681472% 

Tests Skipped Failures Errors Time
198 0 💤 0 ❌ 0 🔥 2m 15s ⏱️

@sophie22
Copy link
Collaborator Author

sophie22 commented Jan 5, 2024

All functions in MagNet task scripts have at least a placeholder docstring in the Google format.

@sophie22 sophie22 requested a review from tomaroberts January 16, 2024 13:37
merge in the Blacks formatting changes
@sophie22
Copy link
Collaborator Author

All functions in ACR task scripts have at least a placeholder docstring in the Google format.

Copy link
Collaborator

@tomaroberts tomaroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start on getting these docstrings filled out.

Just a few comments.

PR is still in draft btw, if you want to undraft it.

hazenlib/ACRObject.py Outdated Show resolved Hide resolved
hazenlib/tasks/acr_spatial_resolution.py Outdated Show resolved Hide resolved
hazenlib/tasks/acr_spatial_resolution.py Outdated Show resolved Hide resolved
hazenlib/tasks/spatial_resolution.py Outdated Show resolved Hide resolved
tests/test_ghosting.py Outdated Show resolved Hide resolved
@sophie22 sophie22 marked this pull request as ready for review January 17, 2024 15:41
@sophie22 sophie22 requested a review from tomaroberts January 17, 2024 15:41
@tomaroberts tomaroberts merged commit c8f540c into main Jan 17, 2024
4 checks passed
@sophie22
Copy link
Collaborator Author

pls don't delete the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardise docstrings
2 participants