Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

156 only add "report" section to results when requested #354

Merged
merged 3 commits into from
Jul 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions hazenlib/tasks/acr_geometric_accuracy.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,16 @@ def run(self) -> dict:

results[self.key(dcm)] = result5

results['reports'] = {'images': self.report_files}

L = result1 + result5
mean_err, max_err, cov_l = self.distortion_metric(L)
print(f"Mean relative measurement error is equal to {np.round(mean_err, 2)}mm")
print(f"Maximum absolute measurement error is equal to {np.round(max_err, 2)}mm")
print(f"Coefficient of variation of measurements is equal to {np.round(cov_l, 2)}%")

# only return reports if requested
if self.report:
results['reports'] = {'images': self.report_files}

return results

def centroid_com(self, dcm):
Expand Down
4 changes: 3 additions & 1 deletion hazenlib/tasks/acr_ghosting.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ def run(self) -> dict:

results[self.key(dcm)] = result

results['reports'] = {'images': self.report_files}
# only return reports if requested
if self.report:
results['reports'] = {'images': self.report_files}

return results

Expand Down
4 changes: 3 additions & 1 deletion hazenlib/tasks/acr_slice_position.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ def run(self) -> dict:

results[self.key(dcm)] = result

results['reports'] = {'images': self.report_files}
# only return reports if requested
if self.report:
results['reports'] = {'images': self.report_files}

return results

Expand Down
4 changes: 3 additions & 1 deletion hazenlib/tasks/acr_slice_thickness.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ def run(self) -> dict:

results[self.key(dcm)] = result

results['reports'] = {'images': self.report_files}
# only return reports if requested
if self.report:
results['reports'] = {'images': self.report_files}

return results

Expand Down
6 changes: 5 additions & 1 deletion hazenlib/tasks/acr_snr.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ def run(self, measured_slice_width=None, subtract=None) -> dict:
f"{self.key(self.data2)} because of : {e}")
traceback.print_exc(file=sys.stdout)

results = {self.key(self.data[0]): snr_results, 'reports': {'images': self.report_files}}
results = {self.key(self.data[0]): snr_results}

# only return reports if requested
if self.report:
results['reports'] = {'images': self.report_files}

return results

Expand Down
6 changes: 5 additions & 1 deletion hazenlib/tasks/acr_spatial_resolution.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,11 @@ def run(self) -> dict:
traceback.print_exc(file=sys.stdout)
continue

results = {self.key(self.data[0]): mtf_results, 'reports': {'images': self.report_files}}
results = {self.key(self.data[0]): mtf_results}

# only return reports if requested
if self.report:
results['reports'] = {'images': self.report_files}

return results

Expand Down
4 changes: 3 additions & 1 deletion hazenlib/tasks/acr_uniformity.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ def run(self) -> dict:

results[self.key(dcm)] = result

results['reports'] = {'images': self.report_files}
# only return reports if requested
if self.report:
results['reports'] = {'images': self.report_files}

return results

Expand Down
7 changes: 5 additions & 2 deletions hazenlib/tasks/ghosting.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,11 @@ def run(self) -> dict:
traceback.print_exc(file=sys.stdout)
continue

results = {'ghosting_results': ghosting_results,
'reports': self.report_files}
results = {'ghosting_results': ghosting_results}

# only return reports if requested
if self.report:
results['reports'] = {'images': self.report_files}

return results

Expand Down
7 changes: 5 additions & 2 deletions hazenlib/tasks/slice_position.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,11 @@ def run(self) -> dict:
result = [str(abs(decimal.Decimal(i) * 1)) for i in result]
del decimal

results = {self.key(self.data[0]): {'slice_positions': result},
'reports': {'images': self.report_files}}
results = {self.key(self.data[0]): {'slice_positions': result}}

# only return reports if requested
if self.report:
results['reports'] = {'images': self.report_files}

return results

Expand Down
4 changes: 3 additions & 1 deletion hazenlib/tasks/slice_width.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ def run(self):
traceback.print_exc(file=sys.stdout)
continue

results['reports'] = {'images': self.report_files}
# only return reports if requested
if self.report:
results['reports'] = {'images': self.report_files}

return results

Expand Down
6 changes: 5 additions & 1 deletion hazenlib/tasks/snr.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ def run(self, measured_slice_width=None) -> dict:
snr_results[f"snr_smoothing_measured_{self.key(dcm)}"] = round(snr, 2)
snr_results[f"snr_smoothing_normalised_{self.key(dcm)}"] = round(normalised_snr, 2)

results = {self.key(self.data[0]): snr_results, 'reports': {'images': self.report_files}}
results = {self.key(self.data[0]): snr_results}

# only return reports if requested
if self.report:
results['reports'] = {'images': self.report_files}

return results

Expand Down
3 changes: 0 additions & 3 deletions hazenlib/tasks/snr_map.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,6 @@ def run(self):
# * Pass kernel_len and roi_size parameters from command line.

results = {}
if self.report:
# Create nested report folder and ignore if already exists
pathlib.Path.mkdir(pathlib.Path(self.report_path), parents=True, exist_ok=True)

for self.current_dcm in self.data:

Expand Down
4 changes: 3 additions & 1 deletion hazenlib/tasks/spatial_resolution.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ def run(self) -> dict:
traceback.print_exc(file=sys.stdout)
continue

results['reports'] = {'images': self.report_files}
# only return reports if requested
if self.report:
results['reports'] = {'images': self.report_files}

return results

Expand Down
4 changes: 3 additions & 1 deletion hazenlib/tasks/uniformity.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ def run(self) -> dict:

results[self.key(dcm)] = result

results['reports'] = {'images': self.report_files}
# only return reports if requested
if self.report:
results['reports'] = {'images': self.report_files}

return results

Expand Down