Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

156 only add "report" section to results when requested #354

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

sophie22
Copy link
Contributor

tiny change as discussed in the Hazen meeting to standardise when and how the "reports" section with file path(s) to report images are added to the results dictionary in all tasks.
remove the creation of a report folder from the snr_map task as it is being created upfront within __init__.py

@sophie22 sophie22 requested a review from tomaroberts July 14, 2023 15:55
@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
hazenlib
   HazenTask.py25388%32–34
   __init__.py1514173%141, 145, 155, 160, 197, 204–209, 220, 223–230, 250–252, 270–272, 291–293, 302, 307, 313, 363, 374, 380–386, 400–401, 405
   exceptions.py21481%17–21
   relaxometry.py3119071%248–266, 640, 699–701, 755, 803–825, 843–858, 1186–1189, 1198–1201, 1213–1226, 1229–1234, 1245–1274
   shapes.py20955%13, 16, 24–29, 32
   tools.py84890%43–50, 92, 101, 117
hazenlib/tasks
   acr_geometric_accuracy.py1465662%38–75, 179–195, 209–233
   acr_ghosting.py1174363%33–55, 93–95, 125–127, 163–196
   acr_slice_position.py1555465%53–76, 154, 215–260
   acr_slice_thickness.py1546458%40–62, 188–243
   acr_snr.py1396057%34–75, 100, 169–179, 212–225, 258–271
   acr_spatial_resolution.py2447470%66–90, 169, 212, 225–234, 323–378
   acr_uniformity.py903363%34–56, 123–140
   ghosting.py1525365%18–35, 50, 112–113, 117, 127–128, 154–156, 173–175, 221–259
   relaxometry.py7271%10–11
   slice_position.py1202381%31, 40–41, 52, 106–107, 133, 213, 220–237
   slice_width.py3575385%34–37, 41, 109, 168–188, 453, 458–459, 465, 470, 532–533, 782–823
   snr.py1656759%49, 66–71, 165–183, 198–207, 225–235, 262–272, 277–287, 318–331, 336–344, 373–386
   snr_map.py104199%291
   spatial_resolution.py2474582%36–39, 43, 64, 149, 208, 334–370
   uniformity.py792075%42–45, 51, 93–94, 101, 135–149
TOTAL290480372% 

Tests Skipped Failures Errors Time
219 0 💤 0 ❌ 0 🔥 3m 10s ⏱️

@tomaroberts tomaroberts self-assigned this Jul 17, 2023
Copy link
Contributor

@tomaroberts tomaroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy to review – thanks for separating out :)

Just a small query regarding one file, otherwise I'll merge.

@sophie22
Copy link
Contributor Author

regarding the snr_map script: I only removed the report folder creation section, as it is being handled centrally in init.py. Further down around line 314 there still is the section for if.report to generate the diagrams/images, intact.

@tomaroberts tomaroberts self-requested a review July 18, 2023 09:47
@tomaroberts tomaroberts merged commit 361e794 into main Jul 18, 2023
@tomaroberts tomaroberts deleted the 156_standardise_report branch August 23, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants