-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new tasks to the CLI #330
Merged
Lucrezia-Cester
merged 2 commits into
release/1.2
from
329-the-cli-has-not-been-updated-for-the-new-tasks
Apr 12, 2023
Merged
added new tasks to the CLI #330
Lucrezia-Cester
merged 2 commits into
release/1.2
from
329-the-cli-has-not-been-updated-for-the-new-tasks
Apr 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YassineAzma
requested changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Just to add that acr_snr, acr_slice_position and acr_geometric_accuracy are also missing.
@YassineAzma added them. GitHub copilot complained they weren't there but for some reason I had decided they shouldn't be added in this PR specifically. |
YassineAzma
approved these changes
Apr 12, 2023
Lucrezia-Cester
deleted the
329-the-cli-has-not-been-updated-for-the-new-tasks
branch
April 12, 2023 09:18
Lucrezia-Cester
restored the
329-the-cli-has-not-been-updated-for-the-new-tasks
branch
April 18, 2023 13:54
tomaroberts
deleted the
329-the-cli-has-not-been-updated-for-the-new-tasks
branch
August 23, 2023 08:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tasks were added by Yassine:
They both run correctly, however they didn't show up in the CLI so when someone types hazen --help they are not included in what the docstring prints out.
I have now added these.
@heyhaleema, could you please check this out?