Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new tasks to the CLI #330

Merged

Conversation

Lucrezia-Cester
Copy link
Contributor

Two tasks were added by Yassine:

  1. ACR_spatial_res and 2)acr_slice_thickness.

They both run correctly, however they didn't show up in the CLI so when someone types hazen --help they are not included in what the docstring prints out.

I have now added these.

@heyhaleema, could you please check this out?

@Lucrezia-Cester Lucrezia-Cester linked an issue Apr 12, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Apr 12, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
hazenlib
   HazenTask.py26388%32–34
   __init__.py1514173%141, 145, 155, 160, 197, 204–209, 220, 223–230, 250–252, 270–272, 291–293, 302, 307, 313, 363, 374, 380–386, 400–401, 405
   exceptions.py21481%17–21
   relaxometry.py3179072%238–256, 631, 690–692, 746, 794–816, 834–849, 1174–1177, 1186–1189, 1201–1214, 1217–1222, 1233–1263
   shapes.py20955%13, 16, 24–29, 32
   tools.py84890%43–50, 92, 101, 117
hazenlib/tasks
   acr_geometric_accuracy.py1455562%38–72, 176–192, 206–230
   acr_ghosting.py1164264%33–53, 91–93, 123–125, 161–194
   acr_slice_position.py1545366%53–74, 152, 213–258
   acr_slice_thickness.py1536359%40–60, 186–241
   acr_snr.py1375858%34–71, 96, 165–175, 208–221, 254–267
   acr_spatial_resolution.py2427270%66–86, 165, 208, 221–230, 319–374
   acr_uniformity.py893264%34–54, 121–138
   ghosting.py1505166%18–32, 47, 109–110, 114, 124–125, 151–153, 170–172, 218–256
   relaxometry.py7271%10–11
   slice_position.py1182281%31, 40–41, 103–104, 130, 210, 217–234
   slice_width.py3595286%34–37, 107, 166–186, 451, 456–457, 463, 468, 530–531, 780–821
   snr.py1636660%62–67, 161–179, 194–203, 221–231, 258–268, 273–283, 314–327, 332–340, 369–382
   snr_map.py106199%294
   spatial_resolution.py2474482%36–39, 62, 147, 206, 332–368
   uniformity.py781976%42–45, 91–92, 99, 133–147
TOTAL289978773% 

Tests Skipped Failures Errors Time
219 0 💤 0 ❌ 0 🔥 3m 4s ⏱️

Copy link
Collaborator

@YassineAzma YassineAzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Just to add that acr_snr, acr_slice_position and acr_geometric_accuracy are also missing.

@Lucrezia-Cester
Copy link
Contributor Author

@YassineAzma added them.

GitHub copilot complained they weren't there but for some reason I had decided they shouldn't be added in this PR specifically.

@Lucrezia-Cester Lucrezia-Cester changed the base branch from main to release/1.2 April 12, 2023 09:18
@Lucrezia-Cester Lucrezia-Cester merged commit a7a7f7c into release/1.2 Apr 12, 2023
@Lucrezia-Cester Lucrezia-Cester deleted the 329-the-cli-has-not-been-updated-for-the-new-tasks branch April 12, 2023 09:18
@Lucrezia-Cester Lucrezia-Cester restored the 329-the-cli-has-not-been-updated-for-the-new-tasks branch April 18, 2023 13:54
@tomaroberts tomaroberts deleted the 329-the-cli-has-not-been-updated-for-the-new-tasks branch August 23, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the CLI has not been updated for the new tasks
2 participants