Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.4.1.beta.1 #1505

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Release v0.4.1.beta.1 #1505

merged 4 commits into from
Jun 26, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Jun 26, 2024

PR Summary

Patch release includes new search field value in benefit finder form content type

Releated Github Issues

https://github.com/GSA/px-benefit-finder/milestone/8?closed=1

Detailed Testing steps

Custom Module Improvements

Add search title in life event #1427

To test in local development site or in dev site.

  • pull changes locally
  • make local development site up at http://localhost
  • if in local, bin/drush cim --partial --source=modules/custom/usagov_benefit_finder/configuration -y
  • navigate to admin/content?combine=&type=bears_life_event&status=All&langcode=All
  • go to life event "Benefit finder: death of a loved one" edit page
  • verify that it has search title field

Criteria uncheck has-child validation #870

Test in local development site or in dev.

  • Pull changes locally
  • Make local development site up at http://localhost
  • Navigate to /admin/content?combine=military&type=bears_criteria&status=All&langcode=All
  • Go to criteria "Deceased served in active military" Edit page
  • Uncheck "Has Child" field
  • Click Save
  • Get error message of "Can not uncheck has-child field
    image

@scottqueen-bixal scottqueen-bixal changed the base branch from dev to main June 26, 2024 18:22
@scottqueen-bixal scottqueen-bixal mentioned this pull request Jun 26, 2024
13 tasks
@scottqueen-bixal scottqueen-bixal changed the title B release v0.4.1.beta.1 Release v0.4.1.beta.1 Jun 26, 2024
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review June 26, 2024 18:23
Copy link
Collaborator

@XavierMetichecchia XavierMetichecchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@scottqueen-bixal scottqueen-bixal merged commit f474ff9 into main Jun 26, 2024
1 check was pending
@scottqueen-bixal scottqueen-bixal deleted the b-release-v0.4.1.beta.1 branch June 26, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants