Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1427 add search title field in life event #1472

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

gchi25
Copy link
Contributor

@gchi25 gchi25 commented Jun 24, 2024

PR Summary

This work adds search title field in life event content type.

Related Github Issue

Detailed Testing steps

To test in local development site or in dev site.

  • pull changes locally
  • make local development site up at http://localhost
  • if in local, bin/drush cim --partial --source=modules/custom/usagov_benefit_finder/configuration -y
  • navigate to admin/content?combine=&type=bears_life_event&status=All&langcode=All
  • go to life event "Benefit finder: death of a loved one" edit page
  • verify that it has search title field

@gchi25 gchi25 self-assigned this Jun 24, 2024
@gchi25 gchi25 requested a review from scottqueen-bixal June 24, 2024 16:30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have so many deleted values here?

Copy link
Contributor

@scottqueen-bixal scottqueen-bixal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have so many deleted config values here?

@scottqueen-bixal scottqueen-bixal merged commit df31db2 into dev Jun 26, 2024
7 checks passed
@scottqueen-bixal scottqueen-bixal deleted the 1427-add-search-title-field-in-life-event branch June 26, 2024 17:58
@gchi25 gchi25 mentioned this pull request Jun 26, 2024
13 tasks
scottqueen-bixal added a commit that referenced this pull request Jun 26, 2024
…-event

1427 add search title field in life event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search title field in life event form
2 participants