This repository has been archived by the owner on May 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
725 update header styling #778
Merged
scottqueen-bixal
merged 6 commits into
multi-life-event-2023
from
725-update-header-styling
May 2, 2023
Merged
725 update header styling #778
scottqueen-bixal
merged 6 commits into
multi-life-event-2023
from
725-update-header-styling
May 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-eligibility into 725-update-header-styling
Pa11y testing results``` > [email protected] test:pa11y > pa11y http://localhost:3000/Welcome to Pa11y
No issues found!
|
Pa11y testing results``` > [email protected] test:pa11y > pa11y http://localhost:3000/Welcome to Pa11y
No issues found!
|
nehemiah-abuga
approved these changes
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have verified the header styling is similar to usa.gov at different screen sizes and the links are working correctly
gchi25
approved these changes
May 2, 2023
Pa11y testing results``` > [email protected] test:pa11y > pa11y http://localhost:3000/Welcome to Pa11y
No issues found!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Try and align what we can with styles to usa.gov
Related Github Issue
Type of change
Please delete options that are not relevant.
Branch Name
725-update-header-styling
Testing environment
Link to a Federalist URL or to be tested on local dev environment.
Detailed Testing steps
Link to testing steps in the issue or list them here:
*NOTE: we are not making style updates to mobile nav, see https://github.com/orgs/GSA/projects/48/views/9?pane=issue&itemId=27162623
we are not making content updates to usa-banner, looks like usa.gov uses both contents, one in english and a different one in spanish - waiting for direction before implementing update in future sprints
Checklist: