Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

725 update header styling #778

Merged
merged 6 commits into from
May 2, 2023

Conversation

scottqueen-bixal
Copy link
Contributor

@scottqueen-bixal scottqueen-bixal commented May 2, 2023

PR Summary

Try and align what we can with styles to usa.gov

Related Github Issue

Type of change

Please delete options that are not relevant.

  • Task
  • Bug fix
  • New feature
  • This change requires a documentation update

Branch Name

725-update-header-styling

Testing environment

Link to a Federalist URL or to be tested on local dev environment.

Detailed Testing steps

Link to testing steps in the issue or list them here:

*NOTE: we are not making style updates to mobile nav, see https://github.com/orgs/GSA/projects/48/views/9?pane=issue&itemId=27162623

we are not making content updates to usa-banner, looks like usa.gov uses both contents, one in english and a different one in spanish - waiting for direction before implementing update in future sprints

  • compare header elements in usa.gov to BEARS application
  • ensure all links are working as expected
  • site should be visually consistent in desktop and mobile (with exception of menu as noted above)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@scottqueen-bixal scottqueen-bixal changed the base branch from main to multi-life-event-2023 May 2, 2023 17:07
@github-actions
Copy link

github-actions bot commented May 2, 2023

Pa11y testing results ``` > [email protected] test:pa11y > pa11y http://localhost:3000/

Welcome to Pa11y

Running Pa11y on URL http://localhost:3000/

No issues found!

@scottqueen-bixal scottqueen-bixal self-assigned this May 2, 2023
@scottqueen-bixal scottqueen-bixal added the bug Something isn't working label May 2, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

Pa11y testing results ``` > [email protected] test:pa11y > pa11y http://localhost:3000/

Welcome to Pa11y

Running Pa11y on URL http://localhost:3000/

No issues found!

@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review May 2, 2023 17:16
@scottqueen-bixal scottqueen-bixal requested a review from a team as a code owner May 2, 2023 17:16
Copy link
Contributor

@nehemiah-abuga nehemiah-abuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified the header styling is similar to usa.gov at different screen sizes and the links are working correctly

@github-actions
Copy link

github-actions bot commented May 2, 2023

Pa11y testing results ``` > [email protected] test:pa11y > pa11y http://localhost:3000/

Welcome to Pa11y

Running Pa11y on URL http://localhost:3000/

No issues found!

@scottqueen-bixal scottqueen-bixal merged commit d2173bd into multi-life-event-2023 May 2, 2023
@scottqueen-bixal scottqueen-bixal deleted the 725-update-header-styling branch May 2, 2023 22:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual inconsistency in header
3 participants