Remove semver module #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rahearn would you mind approving and merging this? |
sorry - just getting back into this repo. Before I approve, what is the intended use of the |
As an example, one might write HCL that uses that module to divine the newest gitref matching the supplied semver, then use that gitref to download and supply a .zip of that release for use in a |
rahearn
approved these changes
May 8, 2024
|
1.0.0 milestone tracker: https://github.com/18F/terraform-cloudgov/milestone/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference this comment... This was a good idea that will not actually work because Terraform wants a static
sourcevalue for modules.I've updated the README.md to refer to
v1.0.0, which is what we should tag once this is merged... Technically I broke backward compatibility when I removed the module, and I think it's time we start using a major version number to signal when that happens.Reverts "Merge pull request #28 from 18F/add-semver-module"
This reverts commit 0b02d60, reversing changes made to 7db01d5.