-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable using these modules with version constraints #28
Conversation
16b8472
to
517a067
Compare
This does not update the main README's examples to use semver; we should probably discuss how best to do that.
517a067
to
4632b71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea, and I think for the main README we could probably do what you're doing in semver/README.md
with the locals block either saying "FILL IN CONSTRAINTS" or doing something like ~>0.7
that will get all updates up to 1.0 and we can keep that more or less constant until we have breaking changes.
So each stanza in the README would look something like this? (Note I'm terrible at understanding version constraint syntax, so I'm kind of guessing based on the sparse examples here. And note this module uses NPM's version constraints, not Terraform's!)
(I also think it might be a good time to start moving those stanzas into a README.md in each subdirectory.) |
Oh oh, wait, you meant actually using the exact same pattern with the |
I did mean that, but also I'm good with either way |
@rahearn or @pauldoomgov can you approve this one? I'd like to merge it in support of moving stuff out of the FAC repo into here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love that this is a purely optional quality of life add-on
Welp, uh, bad news... You cannot use this module's output as the |
Adds a
semver
module that will calculate a tag version from this repository using NPM-style version constraints.This does not update the main README's examples to use this new semver method; we should probably discuss how best to do that before merging, hence the draft state of the PR.