Add design system link styling #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: So that links are styled using the design system, instead of browser defaults.
aduth
commented
Sep 22, 2021
Comment on lines
+5
to
+7
| def add_link(el, *args) | ||
| el.attr['class'] = [*el.attr['class'], 'usa-link'].join(' ') if el.type == :a | ||
| super(el, *args) |
There was a problem hiding this comment.
Could serve as motivation to bump to Ruby >=2.7 😄
Suggested change
| def add_link(el, *args) | |
| el.attr['class'] = [*el.attr['class'], 'usa-link'].join(' ') if el.type == :a | |
| super(el, *args) | |
| def add_link(el, ...) | |
| el.attr['class'] = [*el.attr['class'], 'usa-link'].join(' ') if el.type == :a | |
| super(el, ...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: So that links are styled using the design system, instead of browser defaults.
An alternative can be to configure the
$theme-global-link-stylesSASS variable. However, this applies to all links in the layout, which may have unexpected repercussions. Instead, extending Kramdown ensures that styles are only applied to parsed Markdown content.Kramdown monkey-patching reference: https://github.com/gettalong/kramdown/blob/0b0a9e0/lib/kramdown/parser/kramdown/link.rb#L37-L51