Use design system link styles in documentation #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: Because a design system's documentation should ideally leverage said design system's own link styles.
aduth
commented
Sep 22, 2021
zachmargolis
approved these changes
Sep 22, 2021
| @@ -12,7 +12,7 @@ The color codes listed beneath each name indicate what names can be used with th | |||
| This element has classes <code>bg-primary-lighter</code> and <code>text-primary-dark</code>. | |||
| </div> | |||
|
|
|||
| Read more about <a href="https://v2.designsystem.digital.gov/utilities/color/" target="_blank">the U.S. Web Design System’s color utility classes</a>. | |||
| Read more about [the U.S. Web Design System’s color utility classes](https://designsystem.digital.gov/utilities/color/). | |||
There was a problem hiding this comment.
removing target="_blank" is intentional right? the kramdown doesn't add it back in
There was a problem hiding this comment.
removing
target="_blank"is intentional right? the kramdown doesn't add it back in
Good spot and yes, target="_blank" will be removed with these changes. I don't think this page qualifies for any of the standard exceptions of opening a new tab only when necessary, so I didn't care much to retain it.
This also applies to links on the homepage as well.
|
The current visual regression test failure reflects the link changes, and is expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: GSA-TTS/identity-handbook#163
Why: Because a design system's documentation should ideally leverage said design system's own link styles.
Live preview: https://federalist-2f194a10-945e-4413-be01-46ca6dae5358.app.cloud.gov/preview/18f/identity-style-guide/aduth-docs-links/