Fix highlight button causing issues clicking underlying track features #4594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
highlight_z
branch
from
cd15286 to
ddd653f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bookmark highlights added a clickable button to "show bookmark widget" or "remove bookmark" recently (#4556), but it caused some minor issues interacting with the track surrounding the highlight.
The possible cause was creating a pointerEvents:auto inside of a pointerEvents:none div. This seemed to work ok but maybe caused the weird behavior.
This PR tries to fix it by making the click button a separate div from the highlight div, so there is less reliance on this "stacking" of pointerEvents contexts.
Fixes #4579