Add dropdown menu from bookmark label clicks #4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You get a bit of a weird effect when you're zoomed out with some of the styling that was changed branch: main: Before the label icon buttons were inaccessible at a far zoom, but unobtrusive. I don't personally mind the change if that was an intentional preference. |
cmdcolin
force-pushed
the
remove_bookmark_menu
branch
from
18b1bb1 to
2e301ab
Compare
|
ah no that was unintentional. it is a little debateable whether it might still be good to be clickable or something when zoomed out, but i restored the overflow:hidden for now |
|
thanks for catching that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to 'open bookmark widget' and 'remove bookmark'