attempt at fixing strand for gff3 dumping #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
reviewed
May 8, 2023
| @@ -48,7 +48,7 @@ function formatFeat(f: Feature, parentId?: string, parentRef?: string) { | |||
| f.get('start') + 1, | |||
| f.get('end'), | |||
| f.get('score') || '.', | |||
| f.get('strand') || '.', | |||
| f.get('strand') == 1 ? '+' : f.get('strand') == -1 ? '-' : '.', | |||
There was a problem hiding this comment.
got a weird single quote here
cmdcolin
added a commit
that referenced
this pull request
May 23, 2023
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Jun 30, 2023
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Jul 13, 2023
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Aug 22, 2023
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Sep 25, 2023
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Sep 25, 2023
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Oct 31, 2023
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Nov 3, 2023
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Nov 12, 2023
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Nov 17, 2023
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Nov 21, 2023
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Dec 1, 2023
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Dec 18, 2023
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Jan 3, 2024
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Jan 10, 2024
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Jan 19, 2024
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Feb 9, 2024
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Feb 16, 2024
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Feb 21, 2024
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Mar 12, 2024
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Mar 25, 2024
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
May 28, 2024
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
cmdcolin
added a commit
that referenced
this pull request
Jun 17, 2024
Convert to AbstractTrackModel Fix strand for gff3 save track data (#3688)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is all that's needed to address #3678