Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of the end-of-list indicator in refNameAutocomplete to always display as a disabled item #2101

Merged
merged 9 commits into from
Jul 13, 2021

Conversation

teresam856
Copy link
Contributor

@teresam856 teresam856 commented Jul 2, 2021

Related to issue 2086
Bug came from pull request 2071

  • Fix bug with indicator disappearing after user begins to refine search. Now indicator persists when there are more than 100 results in the dropdown. Also added a warning when the user selects the more results option from the dropdown. Thoughts?
bug_fix.mov
  • removes groupings from the dropdown

with group

without_group

  • removes tooltip from magnifying icon

@teresam856 teresam856 added the bug Something isn't working label Jul 2, 2021
@teresam856 teresam856 changed the title Indicator bugfix 2058 Fixes indicator to the end of ref name dropdown disappearing as user begins to refine search Jul 2, 2021
@teresam856 teresam856 marked this pull request as draft July 2, 2021 18:59
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #2101 (7306df3) into main (8f2dd7b) will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2101      +/-   ##
==========================================
+ Coverage   61.99%   62.01%   +0.02%     
==========================================
  Files         476      476              
  Lines       22788    22780       -8     
  Branches     5350     5351       +1     
==========================================
+ Hits        14127    14128       +1     
+ Misses       8380     8371       -9     
  Partials      281      281              
Impacted Files Coverage Δ
packages/core/TextSearch/TextSearchManager.ts 94.54% <ø> (ø)
...owse1TextSeachAdapter/JBrowse1TextSearchAdapter.ts 85.36% <ø> (ø)
...iew/src/LinearGenomeView/components/ImportForm.tsx 62.16% <25.00%> (+0.82%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 74.71% <81.81%> (-0.82%) ⬇️
packages/core/util/analytics.ts 93.02% <0.00%> (+2.32%) ⬆️
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 87.65% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f2dd7b...7306df3. Read the comment docs.

@teresam856 teresam856 self-assigned this Jul 2, 2021
@garrettjstevens
Copy link
Collaborator

From backlog grooming: to keep this component simple (with the understanding that advanced features are likely to come in an future "advanced search"), for now a good option might be to have the text after the 100 options be disabled (not clickable) and have a short, informative message along the lines of "keep typing for more results".

@carolinebridge
Copy link
Contributor

carolinebridge commented Jul 7, 2021

to add another alternative suggestion for the user messaging portion of this ticket, since this is just a small usability thing, we might be able to get away with something like this, which is simply adding label="some short message" to the TextField component.
image

@teresam856
Copy link
Contributor Author

teresam856 commented Jul 8, 2021

to add another alternative suggestion for the user messaging portion of this ticket, since this is just a small usability thing, we might be able to get away with something like this, which is simply adding label="some short message" to the TextField component.
image

This is a good idea, we could maybe add the same label to the import form... 🤔

@teresam856 teresam856 changed the title Fixes indicator to the end of ref name dropdown disappearing as user begins to refine search Fixes indicator in refNameautocomplete dropdown disappearing and disables it Jul 12, 2021
@teresam856
Copy link
Contributor Author

Update: indicator is now disabled and contains new message
Screen Shot 2021-07-12 at 8 10 32 AM

@teresam856 teresam856 marked this pull request as ready for review July 12, 2021 16:21
Copy link
Contributor

@rbuels rbuels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge, just has a couple of conflicts.

@cmdcolin cmdcolin merged commit 20e3859 into main Jul 13, 2021
@cmdcolin cmdcolin changed the title Fixes indicator in refNameautocomplete dropdown disappearing and disables it Fix behavior of the end-of-list indicator in refNameAutocomplete to always display as a disabled item Jul 13, 2021
@cmdcolin cmdcolin deleted the indicator_bugfix_2058 branch July 13, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants