-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix behavior of the end-of-list indicator in refNameAutocomplete to always display as a disabled item #2101
Conversation
…ng if more than 100 results
Codecov Report
@@ Coverage Diff @@
## main #2101 +/- ##
==========================================
+ Coverage 61.99% 62.01% +0.02%
==========================================
Files 476 476
Lines 22788 22780 -8
Branches 5350 5351 +1
==========================================
+ Hits 14127 14128 +1
+ Misses 8380 8371 -9
Partials 281 281
Continue to review full report at Codecov.
|
From backlog grooming: to keep this component simple (with the understanding that advanced features are likely to come in an future "advanced search"), for now a good option might be to have the text after the 100 options be disabled (not clickable) and have a short, informative message along the lines of "keep typing for more results". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to merge, just has a couple of conflicts.
Related to issue 2086
Bug came from pull request 2071
bug_fix.mov