Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete search box usability #2086

Closed
garrettjstevens opened this issue Jun 29, 2021 · 6 comments
Closed

Autocomplete search box usability #2086

garrettjstevens opened this issue Jun 29, 2021 · 6 comments

Comments

@garrettjstevens
Copy link
Collaborator

I've been trying out the autocomplete search box and have some observations and potential needed fixes. This could possibly be broken into separate issues, but I thought we could do that upon discussing them and making some decisions.

  • If you click on the search box and there are more than 100 sequences, it shows "more results...", but if you start typing and then scroll to the bottom, even if there are more than 100 sequences that match what you typed so far, the "more results..." is missing.
    image
  • If you type something that is both a sequence name and a text search match, sometimes it shows up under "reference sequence," sometimes under "text search results," but never under both. I haven't been able to figure out how to reliably reproduce when it shows up under one or the other, but I feel like it should show up under both categories.
    image
    image
    image
  • The helper text "Enter a sequence or locstring" might be problematic. I think "locString" is a term we use internally, but isn't something a user should be expected to understand.
    image
  • Similarly, "refName" is also probably an internal term and not something users should have to know about.
    image

I've also tried to think about how we could help users know what the search box can do. I thought we could have a more extensive description somehow. One idea I mocked up was having a box that describes what you can do pop up when you click on the search box:
image

@teresam856
Copy link
Contributor

teresam856 commented Jun 29, 2021

  • the first one may be a bug related where the warning gets added, I will take a look at that.
  • we could go back to having both the reference sequence names and text search results with a grouping and limit the number of options we display per grouping.
  • We use the term "locstring" in our user guide here, but could replace both terms for something clearer like displaying first 100 results or 100 options or 100 matches? or instead of having "more results" which could be misleading we can have something like "search for more results..."

@cmdcolin
Copy link
Collaborator

once the user starts typing, we will try to make "no distinction" between a reference sequence search result and a text search result (e.g. get rid of group labels)
this helps address the second concern

@hawrobin
Copy link
Collaborator

I've manually tested this feature on 3 browsers - Safari, Chrome and Mozilla on a mac. The search behaviour seems robust across all platforms. Autocomplete seems to resolve the same term when repeated 10+ times. Case insensitive - switching the same test search term (from lower to upper case) does resolve and return the same feature. It would be nice to use real genomic data so that the location, gene or identifier could be tested but otherwise a really nice feature.

@cmdcolin
Copy link
Collaborator

@hawrobin Can you describe how you tested it?

@cmdcolin
Copy link
Collaborator

I think most of the concerns here are taken care of. There is now a help icon that pops up a dialog box inside the refnameautocomplete

@cmdcolin
Copy link
Collaborator

If there are any concerns about the current design let me know, could unmerge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants