-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-indexed and plaintext VCF Adapter to variants plugin #2068
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2068 +/- ##
==========================================
+ Coverage 61.41% 61.44% +0.03%
==========================================
Files 479 480 +1
Lines 22908 22963 +55
Branches 5249 5264 +15
==========================================
+ Hits 14068 14110 +42
- Misses 8565 8578 +13
Partials 275 275
Continue to review full report at Codecov.
|
could this code work if it was a plain text vcf? could possible check if there is the magic number in the buffer https://en.wikipedia.org/wiki/Gzip e.g. 1f8b and only unzip buffer in that case |
Can you update the PR title to be a "sentence style" title? We try to make them sort of like this cause they appear directly in our changelog (e.g. https://jbrowse.org/jb2/blog/2021/05/24/v1.3.0-release#130-2021-05-24) |
d19c34f
to
768b119
Compare
solves this issue for
jbrowse-plugin-gdc
while providing the functionality to core