Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @material-ui/data-grid #1977

Merged
merged 5 commits into from
May 19, 2021
Merged

Upgrade @material-ui/data-grid #1977

merged 5 commits into from
May 19, 2021

Conversation

cmdcolin
Copy link
Collaborator

This upgrades @material-ui/data-grid to the latest as well as @material-ui/core. The @material-ui/data-grid requires at least node 12 via the engines field

Enables the editable cells for possible use in apollo

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 15, 2021
@cmdcolin
Copy link
Collaborator Author

Observations in #1955 may have been a fluke

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 16, 2021
@rbuels
Copy link
Contributor

rbuels commented May 19, 2021

merge when CI is done

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #1977 (bfb8991) into main (c39430f) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1977      +/-   ##
==========================================
- Coverage   60.83%   60.82%   -0.01%     
==========================================
  Files         471      471              
  Lines       22457    22457              
  Branches     5152     5152              
==========================================
- Hits        13661    13659       -2     
- Misses       8520     8522       +2     
  Partials      276      276              
Impacted Files Coverage Δ
...inearGenomeView/components/RefNameAutocomplete.tsx 89.36% <0.00%> (-4.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39430f...bfb8991. Read the comment docs.

@rbuels rbuels merged commit eea9bd2 into main May 19, 2021
@rbuels rbuels deleted the upgrade_react_scripts_datagrid branch May 19, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants