Skip to content

Commit

Permalink
Merge pull request #1977 from GMOD/upgrade_react_scripts_datagrid
Browse files Browse the repository at this point in the history
Upgrade @material-ui/data-grid
  • Loading branch information
rbuels authored May 19, 2021
2 parents f0b0019 + bfb8991 commit eea9bd2
Show file tree
Hide file tree
Showing 7 changed files with 130 additions and 133 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,28 +4,28 @@ on: pull_request

jobs:
lint:
name: Lint on node 10.x and ubuntu-latest
name: Lint on node 12 and ubuntu-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 10.x
- name: Use Node.js 12
uses: actions/setup-node@v1
with:
node-version: 10.x
node-version: '12'
- name: Install deps and build (with cache)
uses: bahmutov/npm-install@v1
- name: Lint codebase
run: yarn eslint --config .eslintrc.base.json --no-eslintrc --report-unused-disable-directives --max-warnings 0 --ext .js,.ts,.jsx,.tsx .

format:
name: Format on node 10.x and ubuntu-latest
name: Format on node 12 and ubuntu-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 10.x
uses: actions/setup-node@v1
- name: Use Node.js 12
uses: actions/setup-node@v2
with:
node-version: 10.x
node-version: '12'
- name: Install deps and build (with cache)
uses: bahmutov/npm-install@v1
- name: Check codebase format
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ jobs:
run: yarn typecheck

buildwebsite:
name: Build website on node 12.x and ubuntu-latest
name: Build website on node 12 and ubuntu-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 12.x
uses: actions/setup-node@v1
- name: Use Node.js 12
uses: actions/setup-node@v2
with:
node-version: 12.x
node-version: '12'
- name: Install website deps (with cache)
uses: bahmutov/npm-install@v1
with:
Expand All @@ -39,11 +39,11 @@ jobs:
cd website/
yarn build
buildwholerepo:
name: Build whole repo on node 10.x and ubuntu-latest
name: Build whole repo on node 14 and ubuntu-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 10.x
- name: Use Node.js 14
uses: actions/setup-node@v2
with:
node-version: '14'
Expand All @@ -55,14 +55,14 @@ jobs:
run: BUILT_TESTS=1 yarn built-test-ci

buildjbrowseweb:
name: Build only jbrowse-web and upload to s3 on node 10.x and ubuntu-latest
name: Build only jbrowse-web and upload to s3 on node 14 and ubuntu-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 10.x
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 10.x
node-version: '14'
- name: Install deps (with cache)
uses: bahmutov/npm-install@v1
- name: Build project
Expand All @@ -87,7 +87,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 10.x
- name: Use Node.js 14
uses: actions/setup-node@v2
with:
node-version: '14'
Expand Down
2 changes: 1 addition & 1 deletion plugins/variants/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"dependencies": {
"@gmod/tabix": "^1.5.0",
"@gmod/vcf": "^4.0.3",
"@material-ui/data-grid": "^4.0.0-alpha.20",
"@material-ui/data-grid": "^4.0.0-alpha.27",
"@material-ui/icons": "^4.11.2",
"generic-filehandle": "^2.0.0"
},
Expand Down
2 changes: 1 addition & 1 deletion products/jbrowse-desktop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"@jbrowse/plugin-wiggle": "^1.2.0",
"@librpc/web": "rbuels/librpc-web#737bb9706762a52a87169a12c9b59fb241febab0",
"@material-ui/core": "^4.9.5",
"@material-ui/data-grid": "^4.0.0-alpha.20",
"@material-ui/data-grid": "^4.0.0-alpha.27",
"@material-ui/icons": "^4.0.0",
"@material-ui/lab": "^4.0.0-alpha.45",
"clsx": "^1.0.4",
Expand Down
2 changes: 1 addition & 1 deletion products/jbrowse-web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@jbrowse/plugin-wiggle": "^1.2.0",
"@librpc/web": "rbuels/librpc-web#737bb9706762a52a87169a12c9b59fb241febab0",
"@material-ui/core": "^4.9.5",
"@material-ui/data-grid": "^4.0.0-alpha.20",
"@material-ui/data-grid": "^4.0.0-alpha.27",
"@material-ui/icons": "^4.0.0",
"@material-ui/lab": "^4.0.0-alpha.56",
"clsx": "^1.0.4",
Expand Down
4 changes: 0 additions & 4 deletions products/jbrowse-web/src/__snapshots__/rootModel.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Array [
"icon": Object {
"$$typeof": Symbol(react.memo),
"compare": null,
"muiName": "SvgIcon",
"type": Object {
"$$typeof": Symbol(react.forward_ref),
"render": [Function],
Expand All @@ -22,7 +21,6 @@ Array [
"icon": Object {
"$$typeof": Symbol(react.memo),
"compare": null,
"muiName": "SvgIcon",
"type": Object {
"$$typeof": Symbol(react.forward_ref),
"render": [Function],
Expand All @@ -45,7 +43,6 @@ Array [
"icon": Object {
"$$typeof": Symbol(react.memo),
"compare": null,
"muiName": "SvgIcon",
"type": Object {
"$$typeof": Symbol(react.forward_ref),
"render": [Function],
Expand All @@ -58,7 +55,6 @@ Array [
"icon": Object {
"$$typeof": Symbol(react.memo),
"compare": null,
"muiName": "SvgIcon",
"type": Object {
"$$typeof": Symbol(react.forward_ref),
"render": [Function],
Expand Down
Loading

0 comments on commit eea9bd2

Please sign in to comment.