-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make LinearAlignmentsDisplay fully configurable in the UI #1795
Conversation
Co-authored-by: Peter Xie <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1795 +/- ##
=======================================
Coverage 59.19% 59.20%
=======================================
Files 459 459
Lines 21351 21349 -2
Branches 5008 5008
=======================================
Hits 12639 12639
+ Misses 8405 8403 -2
Partials 307 307
Continue to review full report at Codecov.
|
This now contains a full LinearPileupDisplay config and a full LinearSNPCoverageDisplay in the LinearAlignmentsDisplay config, and gets rid of the handful of top-level configs in LinearAlignmentsDisplay config that were mostly duplicates of entries in the LinearSNPCoverageDisplay config. Now all config settings are available in the config editor UI. |
Random thoughts: One thing we could also consider is using "less" mouseover tooltips. They can sometimes (maybe even often) get in the way when you are trying to gesture with the mouse, etc. Another thing to consider is allowing per-base information to be shown by the tooltip. This is done in igv, and can be useful |
Changed the title of this PR since it now is really more about having a fully UI-configurable LinearAlignmentsDisplay than about mouseovers. |
This makes the pileup display config be based off of the linear basic display instead of the base linear display, restoring mouseover that went missing after #1666.
Editing the mouseover callback for an AlignmentsDisplay in the UI doesn't work, though, since you can only edit the top-level config and not the nested PileupDisplay and SNPCoverageDisplay configs. Maybe we need to expose those in the UI somehow?No longer applies, see next comment.