Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "mouseover" config from BaseLinearDisplay to LinearBasicDisplay display #1666

Merged
merged 3 commits into from
Mar 5, 2021

Conversation

garrettjstevens
Copy link
Collaborator

This is a proposal to move the "mouseover" config slot from the BaseLinearDisplay to LinearBasicDisplay. There are some displays, like LinearWiggleDisplay, that extend from the config of BaseLinearDisplay but don't have the same concept of mouseover. This way those types of displays don't have a "mouseover" slot in the config editor that doesn't do anything.

@garrettjstevens garrettjstevens self-assigned this Feb 3, 2021
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 3, 2021
@rbuels rbuels added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 12, 2021
@garrettjstevens garrettjstevens marked this pull request as ready for review March 4, 2021 22:30
@rbuels
Copy link
Contributor

rbuels commented Mar 4, 2021

good to merge as soon as conflicts are resolved

@cmdcolin
Copy link
Collaborator

cmdcolin commented Mar 4, 2021

Is this needed for 1.0.4? Why not delay until 1.1.0 and sync up with jexl?

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #1666 (d7e7cee) into master (e9d049c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1666      +/-   ##
==========================================
- Coverage   58.74%   58.73%   -0.01%     
==========================================
  Files         456      456              
  Lines       21156    21156              
  Branches     5009     5009              
==========================================
- Hits        12428    12427       -1     
- Misses       8418     8419       +1     
  Partials      310      310              
Impacted Files Coverage Δ
...earDisplay/models/baseLinearDisplayConfigSchema.ts 100.00% <ø> (ø)
...genome-view/src/LinearBasicDisplay/configSchema.ts 100.00% <ø> (ø)
...BaseLinearDisplay/components/BaseLinearDisplay.tsx 85.10% <0.00%> (-2.13%) ⬇️
packages/core/util/index.ts 81.81% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d049c...d7e7cee. Read the comment docs.

@cmdcolin
Copy link
Collaborator

cmdcolin commented Mar 5, 2021

I guess on second thoughts let's just go for it :)

@cmdcolin cmdcolin merged commit 2901fae into master Mar 5, 2021
@cmdcolin cmdcolin deleted the mouseover_to_basic_display branch March 5, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants