Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing getMetadataTest #176

Merged
merged 1 commit into from
Apr 16, 2021
Merged

fix failing getMetadataTest #176

merged 1 commit into from
Apr 16, 2021

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Apr 16, 2021

Description

Fixes failing getMetadataTest by using the already existing getter method for the query timeout instead of relying on global static field initialization. This prevents a possible race-condition during application start-up (static class initializer vs. main function).

Corresponding issue

Closes #175

Checklist

this prevents a possible race-condition during appliation start-up (static class initializer vs. main function), fixes #175
@tyrasd tyrasd added bug Something isn't working CI Related to continuous integration (unit tests, build settings, etc.) waiting for review This pull request needs a code review labels Apr 16, 2021
@tyrasd tyrasd marked this pull request as draft April 16, 2021 09:24
@tyrasd tyrasd removed the waiting for review This pull request needs a code review label Apr 16, 2021
@tyrasd tyrasd marked this pull request as ready for review April 16, 2021 09:26
@tyrasd tyrasd added this to the 1.5 milestone Apr 16, 2021
Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find anything similar at the moment.

@tyrasd tyrasd merged commit cda684d into master Apr 16, 2021
@tyrasd tyrasd deleted the fix-issue-175 branch April 16, 2021 10:09
@joker234 joker234 mentioned this pull request May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Related to continuous integration (unit tests, build settings, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getMetadataTest sometimes fails
2 participants