Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMetadataTest sometimes fails #175

Closed
tyrasd opened this issue Apr 15, 2021 · 3 comments · Fixed by #176
Closed

getMetadataTest sometimes fails #175

tyrasd opened this issue Apr 15, 2021 · 3 comments · Fixed by #176
Assignees
Labels
bug Something isn't working CI Related to continuous integration (unit tests, build settings, etc.)
Milestone

Comments

@tyrasd
Copy link
Member

tyrasd commented Apr 15, 2021

Bug Description

see GIScience/ohsome-api-dockerized#29 (comment): sometimes, getMetadataTest fails inexplicably. The bug happens reliably on some computers, but on other machines it never(?) happens. 🤷

General Information

  • Version of the ohsome API: master, 1.4.1, etc?
  • local instance using H2 test data file
  • affects unit tests

Expected Behaviour

The test should not fail.

@tyrasd tyrasd added bug Something isn't working CI Related to continuous integration (unit tests, build settings, etc.) labels Apr 15, 2021
@tyrasd tyrasd added this to the 1.5 milestone Apr 15, 2021
@joker234
Copy link
Member

joker234 commented Apr 16, 2021

Additional Information:

@rtroilo
Copy link
Member

rtroilo commented Apr 16, 2021

I think that's the cause!, because the attribution which is loaded from the database and tested before the timeout is correctly returned.
Btw. we should change this preRun logic anyway and use more spring style configuration.

@tyrasd tyrasd self-assigned this Apr 16, 2021
@joker234
Copy link
Member

joker234 commented Apr 16, 2021

Btw. we should change this preRun logic anyway and use more spring style configuration.

I would agree with that.

We should search for other potential occurrences as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Related to continuous integration (unit tests, build settings, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants