Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate run tests at docker build #29

Merged
merged 17 commits into from
Apr 26, 2021
Merged

Integrate run tests at docker build #29

merged 17 commits into from
Apr 26, 2021

Conversation

MichaelsJP
Copy link
Member

No description provided.

@MichaelsJP MichaelsJP marked this pull request as draft April 15, 2021 13:52
@MichaelsJP MichaelsJP self-assigned this Apr 15, 2021
@MichaelsJP
Copy link
Member Author

MichaelsJP commented Apr 15, 2021 •
edited
Loading

@tyrasd I always get a failed test when I try to run the test suite:

Failed tests: getMetadataTest(org.heigit.ohsome.ohsomeapi.controller.GetControllerTest): expected:<100.0> but was:<0.0>

The docker build command to reproduce:
docker build -t ohsome-api-alpine-test:test --build-arg OHSOMEAPI_VERSION=1.4.1 .

It actually doesn't matter if I'm using latest or another version for the OHSOMEAPI_VERSION var.

Any ideas?

tyrasd
tyrasd reviewed Apr 15, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@tyrasd
Copy link
Member

tyrasd commented Apr 15, 2021

Failed tests: getMetadataTest(org.heigit.ohsome.ohsomeapi.controller.GetControllerTest): expected:<100.0> but was:<0.0>

That's odd. It almost certainly comes from the timeout assertation at https://github.com/GIScience/ohsome-api/blob/1.4.1/src/test/java/org/heigit/ohsome/ohsomeapi/controller/GetControllerTest.java#L71, but at the moment I can't think of a reason why the metadata resource would return the wrong value. 🤔

tyrasd
tyrasd reviewed Apr 15, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
tyrasd
tyrasd reviewed Apr 15, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
tyrasd
tyrasd reviewed Apr 15, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
joker234
joker234 reviewed Apr 15, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@tyrasd tyrasd mentioned this pull request Apr 15, 2021
Closed
@joker234 joker234 mentioned this pull request Apr 16, 2021
Merged
@MichaelsJP MichaelsJP requested a review from tyrasd April 16, 2021 10:14
@MichaelsJP MichaelsJP marked this pull request as ready for review April 16, 2021 10:14
tyrasd
tyrasd reviewed Apr 16, 2021
View reviewed changes
Copy link
Member

@tyrasd tyrasd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but my docker expertise is not very deep to be honest. ^-^ maybe @joker234: can you give it a second look as well?

@MichaelsJP MichaelsJP requested a review from joker234 April 23, 2021 10:09
@MichaelsJP MichaelsJP linked an issue Apr 23, 2021 that may be closed by this pull request
integrate ohsome-api tests run at build time to confirm correct builds #13
Closed
joker234
joker234 reviewed Apr 23, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
MichaelsJP and others added 2 commits April 26, 2021 09:05
@MichaelsJP @joker234
Update Dockerfile
9d0637f 
Co-authored-by: Johannes Visintini <[email protected]>
@MichaelsJP @joker234
Optimize git clone command
9c3207f 
Co-authored-by: Johannes Visintini <[email protected]>
@MichaelsJP MichaelsJP requested a review from joker234 April 26, 2021 07:37
@MichaelsJP MichaelsJP merged commit 64ea9c8 into main Apr 26, 2021
@MichaelsJP MichaelsJP deleted the issue-13-integrate-ohsome-api-tests-run-at-build-time-to-confirm-correct-builds branch April 26, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrasd tyrasd tyrasd left review comments

@joker234 joker234 joker234 approved these changes

Assignees

@MichaelsJP MichaelsJP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

integrate ohsome-api tests run at build time to confirm correct builds
3 participants
@MichaelsJP @tyrasd @joker234