Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support to pass MongoClientSettings as a parameter of Creat… #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ba0007belgrid
Copy link

Ability to pass the MongoClientSettings as a parameter of CreateClient. There are advanced features to be used in Diagnostics (Optl) and OData Linq manipulation, which goes beyond of settings in a config file.

@ba0007belgrid ba0007belgrid requested a review from GFlisch as a code owner July 18, 2022 12:53
@GFlisch
Copy link
Owner

GFlisch commented Aug 3, 2022

Hi @ba0007belgrid, I understand that you want to add the capability to create a Client by providing the settings directly.
But in this case is it not the best to create another implementation where the factory constructor is not injecting the IOptionsMonitor? Because we are forcing to have a configuration defined at the level of the DI and we give another one via the create client method. It is also possible to define the mongodb settings by code in the services configuration... Let me know. Gilles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants