Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nservicebus in arc4u nservicebus packages #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update nservicebus in arc4u nservicebus packages #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Arc4u.Standard.NServiceBus.Core/Arc4u.Standard.NServiceBus.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
<PackageId>Arc4u.Standard.NServiceBus.Core</PackageId>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="NServiceBus" Version="7.8.0" />
<ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' ">
<PackageReference Include="NServiceBus" Version="8.2.3" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net8.0' ">
<PackageReference Include="NServiceBus" Version="9.1.1" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Arc4u.Standard.Dependency\Arc4u.Standard.Dependency.csproj" />
Expand Down
7 changes: 6 additions & 1 deletion src/Arc4u.Standard.NServiceBus.RabbitMQ/Arc4u.Standard.NServiceBus.RabbitMQ.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,14 @@
<PackageId>Arc4u.Standard.NServiceBus.RabbitMQ</PackageId>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="NServiceBus.RabbitMQ" Version="6.1.6" />
<PackageReference Include="System.Reflection.Emit" Version="4.7.0" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' ">
<PackageReference Include="NServiceBus.RabbitMQ" Version="8.0.5" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net8.0' ">
<PackageReference Include="NServiceBus.RabbitMQ" Version="9.1.1" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Arc4u.Standard.Caching\Arc4u.Standard.Caching.csproj" />
<ProjectReference Include="..\Arc4u.Standard.Core\Arc4u.Standard.Core.csproj" />
Expand Down
7 changes: 4 additions & 3 deletions src/Arc4u.Standard.NServiceBus.RabbitMQ/Routing/PublisherRootingTopology.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
using Arc4u.Diagnostics;
using Arc4u.Diagnostics;
using NServiceBus.Transport;
using NServiceBus.Transport.RabbitMQ;
using RabbitMQ.Client;
using System;
using System.Collections.Generic;
using NServiceBus.Unicast.Messages;

namespace Arc4u.NServiceBus.RabbitMQ.Routing
{
Expand All @@ -16,11 +17,11 @@ public PublisherRootingTopology(Func<Type, String> exchangeName)

private Func<Type, String> ExchangeName;

public void SetupSubscription(IModel channel, Type type, string subscriberName)
public void SetupSubscription(IModel channel, MessageMetadata type, string subscriberName)
{
}

public void TeardownSubscription(IModel channel, Type type, string subscriberName)
public void TeardownSubscription(IModel channel, MessageMetadata type, string subscriberName)
{
}

Expand Down
7 changes: 3 additions & 4 deletions src/Arc4u.Standard.NServiceBus/Arc4u.Standard.NServiceBus.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,14 @@
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
<PackageId>Arc4u.Standard.NServiceBus</PackageId>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="NServiceBus" Version="7.8.0" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' ">
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.4" />
<PackageReference Include="NServiceBus" Version="8.2.3" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

NServiceBus API usages detected that may require attention.

The update to NServiceBus version 8.2.3 introduces several usages of critical APIs that might be affected by breaking changes in the new version:

  • IEndpointConfiguration in src/Arc4u.Standard.NServiceBus.Core/IEndpointConfiguration.cs
  • ReceiverEndpointConfigurationBase and SenderEndpointConfigBase classes in respective directories
  • Usage of EndpointConfiguration and TransportExtensions in multiple files

Please ensure that:

  1. All instances of EndpointConfiguration and TransportExtensions are compatible with NServiceBus 8.2.3.
  2. Review the NServiceBus upgrade documentation for any breaking changes.
  3. Conduct thorough testing to verify that the updated package does not introduce regressions.
🔗 Analysis chain

Approve NServiceBus update for .NET 6.0, but verify compatibility.

The update of NServiceBus to version 8.2.3 for .NET 6.0 aligns with the PR objectives. However, this is a significant version bump that may introduce breaking changes.

Please ensure that:

  1. The codebase is compatible with NServiceBus 8.x.
  2. All necessary migration steps have been followed.
  3. The application has been thoroughly tested with this new version.

Run the following script to check for potential compatibility issues:

Syntax error detected in the previous script. Generating a corrected version to continue verification.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for NServiceBus API usage that might be affected by the version update.

# Test: Search for common NServiceBus types and methods that might have changed.
rg --type csharp -i '(INeedInitialization|IWantToRunWhenBusStartsAndStops|IWantToRunBeforeConfigurationIsFinalized|EndpointConfiguration|TransportExtensions)'

Length of output: 4265

Script:

#!/bin/bash
# Description: Search for NServiceBus API usage that might be affected by the version update.

# Test: Search for common NServiceBus types and methods that might have changed.
rg --type csharp -i '(INeedInitialization|IWantToRunWhenBusStartsAndStops|IWantToRunBeforeConfigurationIsFinalized|EndpointConfiguration|TransportExtensions)'

Length of output: 3408

</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'net8.0' ">
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
</ItemGroup>
<PackageReference Include="NServiceBus" Version="9.1.1" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Arc4u.Standard.Caching\Arc4u.Standard.Caching.csproj" />
<ProjectReference Include="..\Arc4u.Standard.Core\Arc4u.Standard.Core.csproj" />
Expand Down