Inactive member organ members and fixes to installation/discharge UX #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small note, this does not yet have an implementation in GEWIS/gewisweb, but we aren't close to deploying this. |
This adds a new member function for organs, `Inactief Lid`. This new function is mutually exclusive with any other functions. Furthermore, I have slightly changed the install/discharge result table. It is now sorted by member instead of installation.
This ensure that members can only be installed once with a specific function.
tomudding
force-pushed
the
feature/inactive-member-of-fraternity
branch
from
642c8c7 to
2da6284
Compare
|
Parity with |
rinkp
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
I think I tested all functionality after this PR. I do think the checker needs to be updated and I made a proposal, but wasn't sure whether I should push it, so I included it in this review.
(apart from the error that is thrown on member edits I think should be solved by df2c1e1)
tomudding
force-pushed
the
feature/inactive-member-of-fraternity
branch
3 times, most recently
from
52ad859 to
1328473
Compare
The `Checker` can now determine that a member cannot be "Lid" AND "Inactief Lid" of the same organ, it guesses whether or not the member should actually be "Lid" or "Inactief Lid", however, there is no guarantee this is correct. Additionally, it can detect "Inactief Lid" members who still have a special role in the organ. Co-Authored-By: rinkp <[email protected]>
tomudding
force-pushed
the
feature/inactive-member-of-fraternity
branch
from
1328473 to
3e3a0ea
Compare
This is the first time that Psalm actually kept complaining about polymorphic calls. This has been address by making the `Checker`'s `Error` a template for the generic type `T`. All specific errors that extend the class now also extend it with a specific class for implementation. Also removes the budget check, as that did not do anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #148.
This adds the
Inactief Lidfunction to organ installation. Additionally, this fixes some UX problems that caused a lot of problems in the past.First and foremost, installations are now sorted per member instead of per installation (date). Furthermore, when discharging a member with function
Lid, if they had additional functions in that organ, they would technically not be a member any more but still have a function (which should not be possible), this has now been fixed by ensuring that any other functions are discharged first. Finally, it was possible to install the same member multiple times (regardless of function), this is not also not possible.Note: discharging of all functions and preventing multiple installations are purely done in the front-end.
This closes #166, fixes #181, and fixes #182.