[Part 2] Re-factor publishing charts - gh-pages #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2021
76creates
reviewed
Aug 24, 2021
ljubon
force-pushed
the
refactor-gh-pages
branch
3 times, most recently
from
f0e2f17 to
51d5310
Compare
added 17 commits
August 26, 2021 01:33
ljubon
force-pushed
the
refactor-gh-pages
branch
2 times, most recently
from
6a465eb to
dc3a7b7
Compare
76creates
reviewed
Aug 26, 2021
76creates
reviewed
Aug 26, 2021
76creates
reviewed
Aug 26, 2021
76creates
reviewed
Aug 26, 2021
76creates
reviewed
Aug 26, 2021
|
|
||
| - id: check | ||
| name: 'Check if chart already exist' | ||
| if: ${{ steps.chart-version.outcome == 'success' }} |
There was a problem hiding this comment.
does this rely only on if clause or we actually need to have Chart.yaml and/or values.yaml found as well? If im not mistaken find wont exit 1 if it doesent match any files
76creates
reviewed
Aug 26, 2021
|
|
||
| - id: package | ||
| name: Package ${{ matrix.chart }}-${{ env.REPO_REF }}.tgz | ||
| if: ${{ steps.chart-version.outcome == 'success' && steps.check.outcome == 'success' }} |
There was a problem hiding this comment.
steps.chart-version.outcome == 'success' is redundant as its needed for steps.check.outcome to be success
76creates
reviewed
Aug 26, 2021
|
|
||
| - id: publish | ||
| name: 'Push ${{ matrix.chart }}-${{ env.REPO_REF }}.tgz to gh-pages' | ||
| if: ${{ steps.package.outcome == 'success' }} |
There was a problem hiding this comment.
looks to me that these if clauses in check, package, and publish are unecesarry if we were to use continue-on-error on checkout-gh-pages and checkout-helm-src only, that seams like a proper step
ljubon
force-pushed
the
refactor-gh-pages
branch
from
dc3a7b7 to
aeb6dbb
Compare
ljubon
force-pushed
the
refactor-gh-pages
branch
from
aeb6dbb to
6c243c3
Compare
This was referenced Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old PR: [Part 2] Re-factor publishing charts - gh-pages #39
Due to cleaning up and dependency over Armada, I'm replacing source branch from:
old
ljubon:gh-pages=>ljubon:refactor-gh-pagesnew==========================================
The goal of this PR is to separate
gh-pagesand source code a.k.achartsand re-use the same workflow to publish all charts across G-Research OSS reposmasterbranchgh-pagesbranchindex.yamlfor repo, raw chart files...etc)NOTE:
src_pathanddst_pathinREPO_CHARTmust end with/src_path": "deployment/helm-k8s/", "dst_path": "siembol/"Here you can find example run for publishing
stormchartsInput:
publish-storm.yamlonmasterbranch (e.g WIP-refactor-master)Action:
publish-charts.yamltriggered with given inputs (e.g WIP-refactor-gh-pages)Output:
gh-pagesupdated with new charts published andindex.yamlupdatedSame for Armada and Siembol
Siembol Input -> Charts output
Armada input -> Charts output
NOTE: 2nd PR #50