Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Part 2] Re-factor publishing charts - gh-pages #39

Closed
wants to merge 5 commits into from

Conversation

ljubon
Copy link
Collaborator

@ljubon ljubon commented Jun 18, 2021

The goal of this PR is to separate gh-pages and source code a.k.a charts

  • master branch
    • place for source code 🙏 (e.g charts, values..etc)
  • gh-pages branch
    • all public relates stuff (e.g index.yaml for repo, raw chart files...etc)

NOTE: 2nd PR #38

@ljubon
Copy link
Collaborator Author

ljubon commented Jun 21, 2021

add latest changes from upstream -> #7
gh-pages is up to date with upstream now

@ljubon ljubon marked this pull request as ready for review June 21, 2021 15:52
@76creates
Copy link
Contributor

Im failing to see how generating index.yaml changes anything for charts GH page yet its a part of new and extended CI?
Looks to me like that besides splitting we are adding some new features as well? Please be bit more verbose on this matter if so, thanks! ⚡

@ljubon
Copy link
Collaborator Author

ljubon commented Jul 9, 2021

Im failing to see how generating index.yaml changes anything for charts GH page yet its a part of new and extended CI?
Looks to me like that besides splitting we are adding some new features as well? Please be bit more verbose on this matter if so, thanks! ⚡

hey @76creates I just saw your last comment, sorry for the late reply 🙏
generating (or updating) index.yaml is same as before helm repo index .
what is shown in the diff for index.yaml is just the latest timestamp i did update index.yaml with current charts
as soon as PR is merged, it will get latest/current state of gh-pages and index.yaml will be latest for helm repo

p.s a bit of background ~ index.yaml file should be updated with each new chart published to gh-pages since that file helm repo (public/remote) is watching when they want to reference our new charts

@76creates
Copy link
Contributor

@ljubon sorry I wasn't clear enough I think, just wanted to make sure that those changes comply with what you described in the PR which is:

The goal of this PR is to separate gh-pages and source code a.k.a charts

if so, please carry on, if not just add it to the PR description as well please ⚡ ty

@ljubon
Copy link
Collaborator Author

ljubon commented Jul 12, 2021

@ljubon sorry I wasn't clear enough I think, just wanted to make sure that those changes comply with what you described in the PR which is:

The goal of this PR is to separate gh-pages and source code a.k.a charts

if so, please carry on, if not just add it to the PR description as well please ⚡ ty

no problem @76creates
i used the same description in both PRs since it's divided in 2 parts (master and gh-pages) 💪

@ljubon
Copy link
Collaborator Author

ljubon commented Aug 2, 2021

ping ping 👀

@ljubon ljubon force-pushed the gh-pages branch 2 times, most recently from 89f6f8d to 516dc76 Compare August 9, 2021 21:59
@ljubon
Copy link
Collaborator Author

ljubon commented Aug 17, 2021

Moving this PR to clean (non-gh-paged) due to dependacy over Armada PR

New PR: #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants