Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disables rules about setState in didmount and didupdate #58

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

fterdal
Copy link
Contributor

@fterdal fterdal commented Jun 28, 2018

Assignee Tasks

Please check all that apply.

  • referenced any relevant issue(s)
  • Adding new rule(s)?
    • Included rule summary verbatim from docs as a comment
    • Placed in the right section (stylistic / node / etc.), in alphabetical order
    • Set to 0 (off), 1 (warn), or 2 (error) as spec'd in contributing guidelines
  • Changing active rule(s) severity?
    • Set to 1 (warn), or 2 (error) as spec'd in contributing guidelines
  • Removing rule(s)?
    • Set to 0 if disabling, or delete only if deprecated

Your PR Notes Here

These warnings are inconsistent with the recommendations we make in Learndot and in slides, and aren't especially instructive.
closes #56

@fterdal fterdal requested a review from glebec June 28, 2018 19:54
@glebec glebec merged commit 7987114 into master Jun 28, 2018
@glebec glebec deleted the set-state-warnings branch June 28, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable setState warnings for didX hooks
2 participants