Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable setState warnings for didX hooks #56

Closed
glebec opened this issue Jun 11, 2018 · 1 comment · Fixed by #58
Closed

Disable setState warnings for didX hooks #56

glebec opened this issue Jun 11, 2018 · 1 comment · Fixed by #58

Comments

@glebec
Copy link
Member

glebec commented Jun 11, 2018 

'react/no-did-mount-set-state': 1, // Prevent usage of setState in componentDidMount
'react/no-did-update-set-state': 1, // Prevent usage of setState in componentDidUpdate

More annoying than helpful, especially with async funcs throwing false positives.

See jsx-eslint/eslint-plugin-react#596
@fterdal
Copy link
Contributor

fterdal commented Jun 28, 2018

I heartily agree with this, and I've had several students complain about this in particular.

@fterdal fterdal mentioned this issue Jun 28, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

disables rules about setState in didmount and didupdate FullstackAcademy/eslint-config-fullstack
2 participants
@fterdal @glebec