test: refactor BooleanCoder tests
#944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success826 tests passing in 127 suites. Report generated by 🧪jest coverage report action from 04acf65 |
…hub.com/FuelLabs/fuels-ts into db/test/refactor-boolean-coder-tests
arboleya
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
LGTM.
----------------|---------|----------|---------|---------|-----------------------------------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------------|---------|----------|---------|---------|-----------------------------------------------
boolean.ts | 87.5 | 80 | 100 | 87.5 | 16,19
Addressed missing coverage
camsjams
approved these changes
May 2, 2023
Torres-ssf
approved these changes
May 2, 2023
arboleya
reviewed
May 2, 2023
| }); | ||
|
|
||
| it('should throw an error when encoding an invalid boolean value', () => { | ||
| const toBytesSpy = jest |
There was a problem hiding this comment.
No need to assign the spy to the toBytesSpy variable here.
arboleya
reviewed
May 2, 2023
| }); | ||
|
|
||
| it('should throw an error when input to encode cannot be converted to bytes', () => { | ||
| const toBytesSpy = jest.spyOn(mathMod, 'toBytes').mockImplementationOnce(() => { |
There was a problem hiding this comment.
No need to assign the spy to the toBytesSpy variable here.
danielbate
added a commit
that referenced
this pull request
May 17, 2023
* test: add individual unit test files for coders * test: implemented abi coder test utils * Revert "test: add individual unit test files for coders" This reverts commit 9d77f9d. * test: refactor `NumberCoder` tests (#949) * test: refactor and increase verbosity of number coder tests * chore: changeset * chore: force rebuild --------- Co-authored-by: danielbate <--global> * test: refactor `B256Coder` tests (#946) * test: refactor and increase verbosity of b256 coder tests * chore: changeset * test: add test for missing throw condition --------- Co-authored-by: danielbate <--global> * test: refactor `B512Coder` tests (#945) * test: refactor and increase verbosity of b512 coder tests * chore: changeset * chore: linting * test: add test case for missing throw condition in b512 coder * test: correct imported class name in b512 coder test Co-authored-by: Sérgio Torres <[email protected]> --------- Co-authored-by: danielbate <--global> Co-authored-by: Sérgio Torres <[email protected]> * test: refactor `BooleanCoder` tests (#944) * test: refactor and increase verbosity of boolean coder tests * chore: changeset * test: add missing test coverage to boolean coder throw conditions --------- Co-authored-by: danielbate <--global> * test: refactor `ByteCoder` tests (#943) * test: refactored byte coder tests * chore: changeset --------- Co-authored-by: danielbate <--global> * test: refactor `TupleCoder` tests (#939) * test: refactor and increase verbosity of tuple coder tests * chore: changeset --------- Co-authored-by: danielbate <--global> * test: refactor `StructCoder` tests (#940) * test: refactor and increase verbosity of struct test * test: fix test number inputs in struct coder test * chore: changeset * test: use template literals for struct name in struct coder test Co-authored-by: Anderson Arboleya <[email protected]> --------- Co-authored-by: danielbate <--global> Co-authored-by: Anderson Arboleya <[email protected]> * test: refactor `ArrayCoder` tests (#937) * test: refactor and increase verbosity of array coder tests * chore: changeset * test: remove redundant describe block from array coder test * test: add missing throw condition testcase to array coder --------- Co-authored-by: danielbate <--global> * test: refactor `U64Coder` tests (#941) * test: refactor and increase verbosity of u64 coder tests * test: remove redundant imports and comments * chore: changeset * chore: force rebuild --------- Co-authored-by: danielbate <--global> * test: refactor `VecCoder` tests (#936) * test: refactor and increase verbosity of vec test * chore: changeset * test: add missing test cases for encoding non array inputs in vec coder --------- Co-authored-by: danielbate <--global> * test: refactor `StringCoder` tests (#972) * test: refactor and increase verbosity of string coder tests * test: remove redundant import * chore: changeset * chore: force rebuild * test: remove commented out tests from string coder --------- Co-authored-by: danielbate <--global> * test: refactor `EnumCoder` tests (#938) * test: refactor and increase verbosity of enum coder tests * chore: changeset * test: introduce test cases for native enums * test: add feature test in abi coder for native enum * test: remove abi coder test case for native enum as redundant --------- Co-authored-by: danielbate <--global> * test: abstract coder tests * refactor: remove coders mass and snapshot tests * chore: remove redundant import in ABI coder * chore: linting * chore: linting * test: remove redundant enum coder tests * test: refactor `OptionCoder` tests (#1006) --------- Co-authored-by: danielbate <--global> Co-authored-by: Sérgio Torres <[email protected]> Co-authored-by: Anderson Arboleya <[email protected]>
danielbate
added a commit
that referenced
this pull request
May 18, 2023
* test: add individual unit test files for coders * test: implemented abi coder test utils * Revert "test: add individual unit test files for coders" This reverts commit 9d77f9d. * test: refactor `NumberCoder` tests (#949) * test: refactor and increase verbosity of number coder tests * chore: changeset * chore: force rebuild --------- Co-authored-by: danielbate <--global> * test: refactor `B256Coder` tests (#946) * test: refactor and increase verbosity of b256 coder tests * chore: changeset * test: add test for missing throw condition --------- Co-authored-by: danielbate <--global> * test: refactor `B512Coder` tests (#945) * test: refactor and increase verbosity of b512 coder tests * chore: changeset * chore: linting * test: add test case for missing throw condition in b512 coder * test: correct imported class name in b512 coder test Co-authored-by: Sérgio Torres <[email protected]> --------- Co-authored-by: danielbate <--global> Co-authored-by: Sérgio Torres <[email protected]> * test: refactor `BooleanCoder` tests (#944) * test: refactor and increase verbosity of boolean coder tests * chore: changeset * test: add missing test coverage to boolean coder throw conditions --------- Co-authored-by: danielbate <--global> * test: refactor `ByteCoder` tests (#943) * test: refactored byte coder tests * chore: changeset --------- Co-authored-by: danielbate <--global> * test: refactor `TupleCoder` tests (#939) * test: refactor and increase verbosity of tuple coder tests * chore: changeset --------- Co-authored-by: danielbate <--global> * test: refactor `StructCoder` tests (#940) * test: refactor and increase verbosity of struct test * test: fix test number inputs in struct coder test * chore: changeset * test: use template literals for struct name in struct coder test Co-authored-by: Anderson Arboleya <[email protected]> --------- Co-authored-by: danielbate <--global> Co-authored-by: Anderson Arboleya <[email protected]> * test: refactor `ArrayCoder` tests (#937) * test: refactor and increase verbosity of array coder tests * chore: changeset * test: remove redundant describe block from array coder test * test: add missing throw condition testcase to array coder --------- Co-authored-by: danielbate <--global> * test: refactor `U64Coder` tests (#941) * test: refactor and increase verbosity of u64 coder tests * test: remove redundant imports and comments * chore: changeset * chore: force rebuild --------- Co-authored-by: danielbate <--global> * test: refactor `VecCoder` tests (#936) * test: refactor and increase verbosity of vec test * chore: changeset * test: add missing test cases for encoding non array inputs in vec coder --------- Co-authored-by: danielbate <--global> * test: refactor `StringCoder` tests (#972) * test: refactor and increase verbosity of string coder tests * test: remove redundant import * chore: changeset * chore: force rebuild * test: remove commented out tests from string coder --------- Co-authored-by: danielbate <--global> * feat: add throw to string coder when encoding value with length mismatch * test: add unit test for string cdoer encoder throw conditon * chore: changeset * chore: force rebuild --------- Co-authored-by: danielbate <--global> Co-authored-by: Sérgio Torres <[email protected]> Co-authored-by: Anderson Arboleya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #753
This PR will:
encodeanddecode