Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor EnumCoder tests #938

Conversation

danielbate
Copy link
Member

Related to #753

This PR will:

  • Introduce a seperate test file for the service under test
  • Seperate test cases for encode and decode
  • Remove snapshot tests to bring expectations into the same test file
  • Remove redundant tests to more clearly report on code coverage

@danielbate danielbate requested a review from a team April 28, 2023 11:39
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
95.11% (-0.27% 🔻)
4703/4945
🟢 Branches
83.97% (-0.54% 🔻)
833/992
🟢 Functions
92.43% (+5.33% 🔼)
903/977
🟢 Lines
95.13% (-0.24% 🔻)
4496/4726
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / normalize.ts
100% 100% 100% 100%
🟢
... / execSync.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / operations.ts
86.44% (-1.69% 🔻)
100%
72.88% (-3.39% 🔻)
91.21% (-1.1% 🔻)
🟡
... / provider.ts
78.85% (-2.08% 🔻)
72.5% (-3.06% 🔻)
79.07% (-2.18% 🔻)
77.85% (-2.15% 🔻)
🟢
... / vec.ts
83.33% (-3.62% 🔻)
25% 83.33%
82.61% (-3.75% 🔻)
🟢
... / json-abi.ts
97.62% (-0.16% 🔻)
86.96% 100%
97.14% (-0.15% 🔻)
🟢
... / interface.ts
84.21% (-1.73% 🔻)
67.86% (-2.14% 🔻)
92.31% (-1.03% 🔻)
83.93% (-1.56% 🔻)
🟢
... / input.ts
93.33%
85.71% (-7.14% 🔻)
100% 92.86%
🟢
... / contract-factory.ts
86.49% (-0.55% 🔻)
66.67% (+4.17% 🔼)
83.33% (-4.17% 🔻)
86.49% (-0.55% 🔻)
🟢
... / predicate.ts
97.22% (-2.78% 🔻)
75% (-17.86% 🔻)
100%
97.14% (-2.86% 🔻)
🟡
... / rewriteVersions.ts
80% (-20% 🔻)
85.71% (-14.29% 🔻)
75% (-25% 🔻)
77.78% (-22.22% 🔻)

Test suite run success

829 tests passing in 127 suites.

Report generated by 🧪jest coverage report action from 5fc0202

@danielbate danielbate self-assigned this Apr 28, 2023
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

----------------|---------|----------|---------|---------|-----------------------------------------------------------
File            | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------------|---------|----------|---------|---------|-------------------------------------------------
  enum.ts                 |   82.97 |    55.55 |     100 |   82.97 | 45-50,55,74,94

@danielbate
Copy link
Member Author

I'd like to get those other lines covered within this PR, I've reached out to @camsjams to provide further input on what we would expect the inputs/outputs for a native enum to look like, and will add to this PR.

@arboleya arboleya requested a review from camsjams May 7, 2023 21:52
@danielbate danielbate merged commit 2527865 into db/test/refactor-abi-coder-coders-tests May 16, 2023
@danielbate danielbate deleted the db/test/refactor-enum-coder-test branch May 16, 2023 15:27
danielbate added a commit that referenced this pull request May 17, 2023
* test: add individual unit test files for coders

* test: implemented abi coder test utils

* Revert "test: add individual unit test files for coders"

This reverts commit 9d77f9d.

* test: refactor `NumberCoder` tests (#949)

* test: refactor and increase verbosity of number coder tests

* chore: changeset

* chore: force rebuild

---------

Co-authored-by: danielbate <--global>

* test: refactor `B256Coder` tests (#946)

* test: refactor and increase verbosity of b256 coder tests

* chore: changeset

* test: add test for missing throw condition

---------

Co-authored-by: danielbate <--global>

* test: refactor `B512Coder` tests (#945)

* test: refactor and increase verbosity of b512 coder tests

* chore: changeset

* chore: linting

* test: add test case for missing throw condition in b512 coder

* test: correct imported class name in b512 coder test

Co-authored-by: Sérgio Torres <[email protected]>

---------

Co-authored-by: danielbate <--global>
Co-authored-by: Sérgio Torres <[email protected]>

* test: refactor `BooleanCoder` tests (#944)

* test: refactor and increase verbosity of boolean coder tests

* chore: changeset

* test: add missing test coverage to boolean coder throw conditions

---------

Co-authored-by: danielbate <--global>

* test: refactor `ByteCoder` tests (#943)

* test: refactored byte coder tests

* chore: changeset

---------

Co-authored-by: danielbate <--global>

* test: refactor `TupleCoder` tests (#939)

* test: refactor and increase verbosity of tuple coder tests

* chore: changeset

---------

Co-authored-by: danielbate <--global>

* test: refactor `StructCoder` tests (#940)

* test: refactor and increase verbosity of struct test

* test: fix test number inputs in struct coder test

* chore: changeset

* test: use template literals for struct name in struct coder test

Co-authored-by: Anderson Arboleya <[email protected]>

---------

Co-authored-by: danielbate <--global>
Co-authored-by: Anderson Arboleya <[email protected]>

* test: refactor `ArrayCoder` tests (#937)

* test: refactor and increase verbosity of array coder tests

* chore: changeset

* test: remove redundant describe block from array coder test

* test: add missing throw condition testcase to array coder

---------

Co-authored-by: danielbate <--global>

* test: refactor `U64Coder` tests (#941)

* test: refactor and increase verbosity of u64 coder tests

* test: remove redundant imports and comments

* chore: changeset

* chore: force rebuild

---------

Co-authored-by: danielbate <--global>

* test: refactor `VecCoder` tests (#936)

* test: refactor and increase verbosity of vec test

* chore: changeset

* test: add missing test cases for encoding non array inputs in vec coder

---------

Co-authored-by: danielbate <--global>

* test: refactor `StringCoder` tests (#972)

* test: refactor and increase verbosity of string coder tests

* test: remove redundant import

* chore: changeset

* chore: force rebuild

* test: remove commented out tests from string coder

---------

Co-authored-by: danielbate <--global>

* test: refactor `EnumCoder` tests (#938)

* test: refactor and increase verbosity of enum coder tests

* chore: changeset

* test: introduce test cases for native enums

* test: add feature test in abi coder for native enum

* test: remove abi coder test case for native enum as redundant

---------

Co-authored-by: danielbate <--global>

* test: abstract coder tests

* refactor: remove coders mass and snapshot tests

* chore: remove redundant import in ABI coder

* chore: linting

* chore: linting

* test: remove redundant enum coder tests

* test: refactor `OptionCoder` tests (#1006)

---------

Co-authored-by: danielbate <--global>
Co-authored-by: Sérgio Torres <[email protected]>
Co-authored-by: Anderson Arboleya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants