Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing WASM-NPM packaging and publishing (#835) #839

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Sep 26, 2024

  • Upgrading turbo and pnpm

  • DRY

  • Adjusting regex to match any variable name; not only input

  • Updating changelog

  • Fixing pnpm version for workflow

  • Adding tests to check if all output files have been patched successfully

  • Fixing turbo pipeline

  • Adjusting pnpm version

  • Trying relative static paths

  • Adding temporary log call

(cherry picked from commit dffc2b4)

* Upgrading turbo and pnpm

* DRY

* Adjusting regex to match any variable name; not only `input`

* Updating changelog

* Fixing pnpm version for workflow

* Adding tests to check if all output files have been patched successfully

* Fixing turbo pipeline

* Adjusting pnpm version

* Trying relative static paths

* Adding temporary log call

(cherry picked from commit dffc2b4)
@xgreenx xgreenx requested a review from arboleya September 26, 2024 18:08
@xgreenx xgreenx self-assigned this Sep 26, 2024
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. ❤️

@xgreenx xgreenx merged commit 5faa8cd into release/v0.57.1 Sep 26, 2024
35 checks passed
@xgreenx xgreenx deleted the hotfix/fix-publishing-of-wasm branch September 26, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants