Fixing WASM-NPM packaging and publishing #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2024
arboleya
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
Torres-ssf
approved these changes
Sep 26, 2024
danielbate
approved these changes
Sep 26, 2024
nedsalk
approved these changes
Sep 26, 2024
xgreenx
approved these changes
Sep 26, 2024
xgreenx
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Upgrading turbo and pnpm * DRY * Adjusting regex to match any variable name; not only `input` * Updating changelog * Fixing pnpm version for workflow * Adding tests to check if all output files have been patched successfully * Fixing turbo pipeline * Adjusting pnpm version * Trying relative static paths * Adding temporary log call (cherry picked from commit dffc2b4)
xgreenx
added a commit
that referenced
this pull request
Sep 26, 2024
* Upgrading turbo and pnpm * DRY * Adjusting regex to match any variable name; not only `input` * Updating changelog * Fixing pnpm version for workflow * Adding tests to check if all output files have been patched successfully * Fixing turbo pipeline * Adjusting pnpm version * Trying relative static paths * Adding temporary log call (cherry picked from commit dffc2b4) Co-authored-by: Anderson Arboleya <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated WASM/JS code changed in v
0.57.0, and the regexes used to patch it stopped working.This prevented dependent NPM packages, including the TS SDK and all apps using it, from building.
This PR fixes those regexes and updates the essential tools used for packaging.
Before requesting review