Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up overflow conditions #588

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Clean up overflow conditions #588

merged 2 commits into from
Jul 1, 2024

Conversation

Dentosal
Copy link
Member

Clarifies for all operations that pointer operation overflow (over Word::MAX) and over VM_MAX_RAM both panic. Unifies the formatting for this.

Before requesting review

  • I have reviewed the code myself

@Dentosal Dentosal self-assigned this Jun 18, 2024
@Dentosal Dentosal requested a review from a team June 18, 2024 16:01
@Dentosal Dentosal added the comp:FVM Component: FuelVM label Jun 18, 2024
@Dentosal Dentosal marked this pull request as ready for review June 18, 2024 16:01
@xgreenx xgreenx merged commit b40d87d into master Jul 1, 2024
5 of 6 checks passed
@xgreenx xgreenx deleted the dento/cleanup-overflow-conditions branch July 1, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

Assignees

@Dentosal Dentosal

Labels
comp:FVM Component: FuelVM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dentosal @xgreenx