Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GM_BASE_ASSET_ID #561

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Add GM_BASE_ASSET_ID #561

merged 2 commits into from
Mar 21, 2024

Conversation

Dentosal
Copy link
Member

@Dentosal Dentosal commented Mar 20, 2024 •
edited
Loading

Closes #559

VM PR: FuelLabs/fuel-vm#700

@Dentosal Dentosal added the comp:FVM Component: FuelVM label Mar 20, 2024
@Dentosal Dentosal requested a review from a team March 20, 2024 22:58
@Dentosal Dentosal self-assigned this Mar 20, 2024
@Dentosal Dentosal mentioned this pull request Mar 20, 2024
Merged
@Voxelot
Copy link
Member

Voxelot commented Mar 21, 2024 •
edited
Loading

We also need to update the memory initialization spec

image

Voxelot
Voxelot previously requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@Voxelot Voxelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change affects vm memory initialization which needs to be documented

@Dentosal
Copy link
Member Author

Updated VM initilaization in 8ecaae0

@Dentosal Dentosal requested review from Voxelot and a team March 21, 2024 04:03
@Dentosal Dentosal dismissed Voxelot’s stale review March 21, 2024 21:57

Fixed, going to merge on two approvals

@Dentosal Dentosal merged commit 184f86f into master Mar 21, 2024
6 checks passed
@Dentosal Dentosal deleted the dento/gm-base-asset-id branch March 21, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

@MitchTurner MitchTurner MitchTurner approved these changes

@Voxelot Voxelot Awaiting requested review from Voxelot

Assignees

@Dentosal Dentosal

Labels
comp:FVM Component: FuelVM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GM getter for the base asset id
4 participants
@Dentosal @Voxelot @MitchTurner @xgreenx