Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GM getter for the base asset id #559

Closed
xgreenx opened this issue Mar 14, 2024 · 2 comments · Fixed by #561
Closed

Add GM getter for the base asset id #559

xgreenx opened this issue Mar 14, 2024 · 2 comments · Fixed by #561
Assignees
@Dentosal

Comments

@xgreenx
Copy link
Contributor

xgreenx commented Mar 14, 2024

No description provided.

@Dentosal
Copy link
Member

@xgreenx GM is a bit weird opcode for this, as it currently returns either Word-sized value or a pointer to memory. In this case there seems to be no requirement for the base asset id to exist in memory, so there's nowhere to point to. Or maybe it's always part of runtime balances and we could point to the value in that array?

@Dentosal Dentosal changed the title Add GM getter for the basic asset id Add GM getter for the base asset id Mar 20, 2024
@Dentosal
Copy link
Member

As discussed, the way to do this is adding the base asset id to memory on VM startup.

@Dentosal Dentosal mentioned this issue Mar 20, 2024
Merged
Dentosal added a commit that referenced this issue Mar 21, 2024
@Dentosal
Add GM_BASE_ASSET_ID (#561)
184f86f 
Closes #559

VM PR: FuelLabs/fuel-vm#700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dentosal Dentosal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add GM_BASE_ASSET_ID FuelLabs/fuel-specs
2 participants
@Dentosal @xgreenx