Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fuel-core-keygen support --version arg #1514

Closed
wants to merge 1 commit into from

Conversation

lilasxie
Copy link

@lilasxie lilasxie commented Nov 24, 2023

Close #1495

image

@xgreenx
Copy link
Collaborator

xgreenx commented Nov 24, 2023

Thank you, but we don't want to accept super small PRs from accounts without real Github activity

@xgreenx xgreenx closed this Nov 24, 2023
@lilasxie
Copy link
Author

Thank you, but we don't want to accept super small PRs from accounts without real Github activity

This is ridiculous. As this is a PR for a good_first_issue, and just a bug fix, no more code is needed.

@lilasxie
Copy link
Author

lilasxie commented Nov 24, 2023

Thank you, but we don't want to accept super small PRs from accounts without real Github activity

And what do you mean by saying 'no real Github activity'? I'm doing some contributions to open-source project, and I need to work also, no one should be stay github all the day.

@xgreenx
Copy link
Collaborator

xgreenx commented Nov 24, 2023

The problem is that you created a bunch of small PRs in several blockchain projects.

image

For example, the change below is unnecessary at all:
image

It looks like you are trying to get some contributions for the twink account to blockchain projects to receive some airdrops in the future.

We are happy to accept small contributions from the main GitHub account. If it is a new account(twink), we are okay with accepting really valuable changes.

@lilasxie
Copy link
Author

lilasxie commented Nov 24, 2023

The problem is that you created a bunch of small PRs in several blockchain projects.

image For example, the change below is unnecessary at all: image

It looks like you are trying to get some contributions for the twink account to blockchain projects to receive some airdrops in the future.

We are happy to accept small contributions from the main GitHub account. If it is a new account(twink), we are okay with accepting really valuable changes.

Okay, I got you. It is up to u to judge me like this. But here are some clarification:

  1. As you mentioned about the PR for osmosis, if u are new to golang, plz re-check for the PR as I described. This PR is created when I reviewed the code, and was confused about the variable declared, although this makes no real effect for running, but for reading.
  2. No matter what am I a new account, or twink, doesn't this "fix" PR make a valuable changes? As this is a issue opend by your team, not purposely opend by myself😀
  3. I don't care about the airdrop, I care about what I can do for the world😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fuel-core-keygen should support --version arg
2 participants