Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuel-core-keygen should support --version arg #1495

Closed
sdankel opened this issue Nov 17, 2023 · 4 comments · Fixed by #1515
Closed

fuel-core-keygen should support --version arg #1495

sdankel opened this issue Nov 17, 2023 · 4 comments · Fixed by #1515
Assignees
@xgreenx
Labels
good first issue Good for newcomers

Comments

@sdankel
Copy link
Member

sdankel commented Nov 17, 2023

Fuelup expects all components to implement the --version argument.

Related: FuelLabs/fuelup#508
@sdankel sdankel added the good first issue Good for newcomers label Nov 17, 2023
@richardgreg
Copy link

Hi @sdankel, I would like to take up this issue.

@sdankel
Copy link
Member Author

sdankel commented Nov 19, 2023

Hi @sdankel, I would like to take up this issue.

@richardgreg Feel free to send a PR 😄

@lilasxie
Copy link

lilasxie commented Nov 24, 2023 •
edited
Loading

@sdankel @richardgreg Hi, just met the fuel-core-keygen Error getting version string error and find the issue here. I have fixed this issue, can I take up this PR? 😀
image

@lilasxie lilasxie mentioned this issue Nov 24, 2023
Closed
@xgreenx xgreenx mentioned this issue Nov 24, 2023
Merged
@richardgreg
Copy link

@lilasxie sure 👌

xgreenx added a commit that referenced this issue Nov 24, 2023
@xgreenx
Added support of --version command for fuel-core-keygen binary (#…
58b452f 
…1515)

Closes #1495
@xgreenx xgreenx self-assigned this Nov 27, 2023
crypto523 pushed a commit to crypto523/fuel-core that referenced this issue Oct 7, 2024
Added support of --version command for fuel-core-keygen binary (#…
62707db 
…1515)

Closes FuelLabs/fuel-core#1495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xgreenx xgreenx

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
4 participants
@xgreenx @lilasxie @richardgreg @sdankel